Version: (using KDE Devel) Installed from: Compiled sources In kvt-core/kvd_vcb.cpp file there is if statement: if (s.stripWhiteSpace().length() >= 0) { tdate = s.toInt(); } This is a comparison of unsigned expression >= 0 that is always true. IMHO this test is pointless and should be removed.
I agree that the test most likely can just be removed. However, if you have a Vocabbox file available I would like to have it for testing purposes (attach to this bug report). The Vocabbox program seems to no longer be available.
Created attachment 8706 [details] VocabBox
I've found VocabBox sources (in README you can find how to create vocabulary file). Is it ok, or should I search vocabulary file?
CVS commit by hedlund: Correct import of Vocabbox files. BUG:94935 M +15 -17 kvd_vcb.cpp 1.10 --- kdeedu/kvoctrain/kvoctrain/kvt-core/kvd_vcb.cpp #1.9:1.10 @@ -1,6 +1,4 @@ /*************************************************************************** - $Id$ - maintain a document in vocabbox format @@ -9,7 +7,7 @@ begin : Thr Mar 23 21:00:53 MET 1999 - copyright : (C) 1999-2001 Ewald Arnold + copyright : (C) 1999-2001 Ewald Arnold <kvoctrain@ewald-arnold.de> (C) 2001 The KDE-EDU team - email : kvoctrain@ewald-arnold.de + (C) 2004 Peter Hedlund <peter@peterandlinda.com> ----------------------------------------------------------------------- @@ -160,5 +158,5 @@ bool kvoctrainDoc::loadFromVcb (QTextStr } - if (s.stripWhiteSpace().length() >= 0) { + if (s.stripWhiteSpace().length() > 0) { tdate = s.toInt(); }