Bug 89544 - compilation error caused by wrong #include for DragonFlyBSD
Summary: compilation error caused by wrong #include for DragonFlyBSD
Status: RESOLVED INTENTIONAL
Alias: None
Product: kio
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: FreeBSD Ports Other
: NOR normal with 10 votes (vote)
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-15 08:04 UTC by Emiel Kollof
Modified: 2005-06-11 13:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emiel Kollof 2004-09-15 08:04:44 UTC
Version:           3.3.3 (using KDE KDE 3.3.0)
Installed from:    FreeBSD Ports
Compiler:          GCC 2.95.3 
OS:                Other

qanimationwriter.cpp includes <netinet/in.h> to get ntohl(), but has to use <sys/param.h> on DragonFlyBSD (and maybe others). 

Solution:
Add a #include <sys/param.h> to the includes.
Comment 1 Emiel Kollof 2004-09-15 16:22:36 UTC
kdebase kio_ldap is affected too.
Comment 2 Emiel Kollof 2004-09-15 16:30:54 UTC
See bug http://bugs.kde.org/show_bug.cgi?id=89577
Comment 3 Joerg Sonnenberger 2004-09-15 16:57:23 UTC
The Single Unix Specification specifies <arpa/inet.h> as primary header for the ntohl family. Including this file is the most correct solution, e.g. on NetBSD <netinet/in.h> doesn't provide them too.

In http://www.opengroup.org/onlinepubs/007908799/xns/netinetin.h.html is a comment that the ntohl is visible, but the comment about arpa/inet.h suggests that the internal inclusion is somewhat meant.

The DragonFly header will be changed to include arpa/inet.h, but KDE code base is better off using arpa/inet.h directly.
Comment 4 Nicolas Goutte 2004-09-18 18:00:45 UTC
Please report Qt-only bugs to qt-bugs at trolltech,com
(See http://doc.trolltech.com/3.3/bughowto.html or the corresponding file in your Qt documentation.)

As this bug is for kio_ldap too, moving this bug to kio.

Have a nice day!
Comment 5 Nicolas Goutte 2005-06-11 13:02:16 UTC
As the change asked by bug #89577 was reversed, it does not seem to be needed to keep this bug open.

If you still thing that this bug or #89577 is really useful, then please tell. We can still re-open the 2 bugs.

Have a nice day!