Bug 61118 - Multiple Close buttons on EstateDetails
Summary: Multiple Close buttons on EstateDetails
Status: RESOLVED FIXED
Alias: None
Product: atlantik
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Rob Kaper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-12 00:14 UTC by Rob Kaper
Modified: 2003-07-14 00:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Kaper 2003-07-12 00:14:52 UTC
Version:           0.5.3 (using KDE 3.1.9)
Compiler:          gcc version 3.2
OS:          Linux (i686) release 2.4.19

Multiple Close buttons appear on the EstateDetails when accepting/finishing a trade during an auction.

If only the official rules specified that auctions or trades should be modal.. I should probably just put these dialogs in a new window instead of embedding them.
Comment 1 Rob Kaper 2003-07-14 00:31:02 UTC
Subject: KDE_3_1_BRANCH: kdegames/atlantik

CVS commit by kaper: 

backport for fix bug #61118: Multiple Close buttons

CCMAIL: 61118-done@bugs.kde.org


  M +1 -0      ChangeLog   1.121.4.21
  M +1 -0      TODO   1.144.4.4
  M +7 -5      libatlantikui/estatedetails.cpp   1.12.4.5


--- kdegames/atlantik/ChangeLog  #1.121.4.20:1.121.4.21
@@ -14,4 +14,5 @@
 - sort user column in server list by number, not alphabetically
 - show non-game users when not in a game
+- prevent double close buttons on estate details
 
 0.5.2

--- kdegames/atlantik/TODO  #1.144.4.3:1.144.4.4
@@ -17,4 +17,5 @@
 - Update messages views after resize.
 - all player/core dependencies in Board should only be there in Mode::Play
+- don't display trade results over auction, but stack it behind it in the queue
 
 For 0.6.0

--- kdegames/atlantik/libatlantikui/estatedetails.cpp  #1.12.4.4:1.12.4.5
@@ -223,4 +223,6 @@ void EstateDetails::addButton(QString co
 void EstateDetails::addCloseButton()
 {
+        if (!m_closeButton)
+        {
         m_closeButton = new KPushButton(i18n("Close"), this);
         m_buttonBox->addWidget(m_closeButton);
@@ -226,6 +228,6 @@ void EstateDetails::addCloseButton()
         m_buttonBox->addWidget(m_closeButton);
         m_closeButton->show();
-
         connect(m_closeButton, SIGNAL(pressed()), this, SIGNAL(buttonClose()));
+        }
 }