Bug 517197 - [Android] Crop Tool doesn't crop when double touch tapping to confirm
Summary: [Android] Crop Tool doesn't crop when double touch tapping to confirm
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (other bugs)
Version First Reported In: 5.2.16
Platform: Android Android 14.x
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2026-03-06 15:58 UTC by Door1
Modified: 2026-03-17 13:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Door1 2026-03-06 15:58:53 UTC
SUMMARY
[Android] Crop Tool doesn't crop when double touch tapping to confirm


STEPS TO REPRODUCE
1. Select Crop Tool
2. Select the part of the canvas you want to crop
3. With finger on screen, perform a double touch tap on the canvas to try to perform the crop

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
The canvas gets cropped, like it would happen if you were using double click on a mouse.

SOFTWARE/OS VERSIONS
Krita 5.2.16 stable / 5.3 beta 3
Android 16
arm64 apk
Comment 1 dra.w.p.il.e+bugskde 2026-03-16 22:46:30 UTC
Same goes for tablet inputs on Android and Linux, the tool only accepts double-clicks coming from a mouse.
Comment 2 Bug Janitor Service 2026-03-16 23:56:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2706
Comment 3 Dmitry Kazakov 2026-03-17 13:17:52 UTC
Git commit aa16b4b42443f73566169c94c8b79acf7ca037e2 by Dmitry Kazakov, on behalf of Carsten Hartenfels.
Committed on 17/03/2026 at 10:36.
Pushed by dkazakov into branch 'master'.

Make non-mouse multi-clicks in KisTools work

By using the underlying KoToolProxy multi-click count instead of only
looking for literal double-click events. Tablet and touch inputs don't
have a separate double-click event, so e.g. the crop and polyline tool
only reacted to them coming from an actual mouse. Now they work for all
kinds of input, like they do for KoTools.
Related: bug 517136

M  +5    -0    libs/flake/KoToolProxy.cpp
M  +1    -1    libs/flake/KoToolProxy.h
M  +2    -2    libs/ui/canvas/kis_tool_proxy.cpp

https://invent.kde.org/graphics/krita/-/commit/aa16b4b42443f73566169c94c8b79acf7ca037e2
Comment 4 Dmitry Kazakov 2026-03-17 13:18:18 UTC
Git commit f231b24cbe41366609e857b89ae6b0829747e78a by Dmitry Kazakov.
Committed on 17/03/2026 at 13:18.
Pushed by dkazakov into branch 'krita/6.0'.

Make non-mouse multi-clicks in KisTools work

By using the underlying KoToolProxy multi-click count instead of only
looking for literal double-click events. Tablet and touch inputs don't
have a separate double-click event, so e.g. the crop and polyline tool
only reacted to them coming from an actual mouse. Now they work for all
kinds of input, like they do for KoTools.
Related: bug 517136


(cherry picked from commit aa16b4b42443f73566169c94c8b79acf7ca037e2)

Co-authored-by: Carsten Hartenfels <carsten.hartenfels@pm.me>

M  +5    -0    libs/flake/KoToolProxy.cpp
M  +1    -1    libs/flake/KoToolProxy.h
M  +2    -2    libs/ui/canvas/kis_tool_proxy.cpp

https://invent.kde.org/graphics/krita/-/commit/f231b24cbe41366609e857b89ae6b0829747e78a