Bug 512416 - Adding tags by drag and drop is broken
Summary: Adding tags by drag and drop is broken
Status: RESOLVED NOT A BUG
Alias: None
Product: digikam
Classification: Applications
Component: Tags-Engine (other bugs)
Version First Reported In: 8.8.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-21 04:20 UTC by kde
Modified: 2025-12-25 10:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 9.0.0
Sentry Crash Report:


Attachments
The broken menu (32.68 KB, image/png)
2025-11-21 04:20 UTC, kde
Details
Dragging an image to a new tag (2.67 MB, video/mp4)
2025-11-21 08:36 UTC, kde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kde 2025-11-21 04:20:41 UTC
Created attachment 187014 [details]
The broken menu

SUMMARY
When draggin pictures from the thumbnails view to the Tags tree panel, the menu is presented with a bad option (Assign Tag '1' to items) no matter which tag we drag it to. Also, once we click on this option, the background task seems to start but no tag gets added to the picture.

STEPS TO REPRODUCE
1. Get pictures to show in the thumbnail view
2. Pick anyone and drag it to a category (it doesn't already have to make sure it should add it)
3. Click on the broken option "Assign Tag '1' to items"

OBSERVED RESULT
After step 2, you see the menu presented in the screenshot as if a bad format string was used.
After step 3, the beckground task panel pops, says it completed but the image is still not tagged.

EXPECTED RESULT
After step 2, according to the screenshot provided, the action label to be "Assign Tag 'Le Manoir' to items".
After step 3, the tag to be written to the picture both in the DB and inside the file.

SOFTWARE/OS VERSIONS
Windows: 11 24H2
KDE Frameworks Version: 6.17.0
Qt Version: 6.9.1

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2025-11-21 07:09:19 UTC
This isn't a bug. The tag assignment has always worked a little differently than you might expect.

You select the tags you want to assign to the images on the left or right side of the tag tree and then drag the images into the tag tree. The popup then shows that you will assign X tags; in your case, you selected 1 tag.

Maik
Comment 2 kde 2025-11-21 07:35:14 UTC
But still, the tag wasn't assigned... Am I missing something for this too? And if so, why is it not working?
And what I still think is a bug is how it is worded: it should be "Assign X tags to items" or even better, "Assign X tags to Y items".
"Assign Tag(s) 'X' to items" make no sense.
Comment 3 kde 2025-11-21 07:35:50 UTC
But still, the tag wasn't assigned... Am I missing something for this too? And if so, why is it not working?
And what I still think is a bug is how it is worded: it should be "Assign X tags to items" or even better, "Assign X tags to Y items".
"Assign Tag(s) 'X' to items" make no sense.
Comment 4 Maik Qualmann 2025-11-21 08:00:56 UTC
We can change the wording. However, it makes little sense to do this in the left-hand tag tree, although there are scenarios for doing so, such as assigning the selected tags to all images. The images have already been filtered for the selected tags, meaning they already contain these tags; they will therefore be assigned again. Use the tag tree in the right sidebar or the reverse drag-and-drop method.

Maik
Comment 5 Maik Qualmann 2025-11-21 08:02:47 UTC
Just to clarify, it doesn't matter where you drop the images; the chosen tags will be assigned.

Maik
Comment 6 kde 2025-11-21 08:36:17 UTC
Created attachment 187018 [details]
Dragging an image to a new tag

Then the UI is very confusing... As you can see on the screenvid, I took a photo that is in "228 rue St-Joseph/Le Cercle" and dragged it on "2508 Boulevard Wilfrid-Hamel". The UI clearly shows it should work as it selects the node and a + icon is added to the dragged thumbnail. Also, I get the popup telling me it will add 1 tag (without naming it). Everything points to the fact "2508 Boulevard Wilfrid-Hamel" should be added to the picture but it won't.

As Microsoft would say, "This behavior is by design" but I'm under the impression that from a UX perspective, the design is flawed and counter-intuitive. Why allow drag & drop if where you drop has no meaning?
Comment 7 Maik Qualmann 2025-11-21 09:39:46 UTC
The destination location doesn't matter (the destination is the entire tag tree) with this drag-and-drop direction, since the selected tag(s) are assigned to the images.

Why not use the "Tag to Items" direction? That might be more logical.
In fact, the tags tree in the right sidebar is better suited for setting tags and is also the intended method.

Maik
Comment 8 Maik Qualmann 2025-11-21 11:33:27 UTC
Git commit 48009b610643d524aecd4cb7f549dee14fe93014 by Maik Qualmann.
Committed on 21/11/2025 at 11:32.
Pushed by mqualmann into branch 'master'.

fix 18np to show assign tag names
FIXED-IN: 8.9.0

M  +2    -2    core/app/dragdrop/tagdragdrop.cpp

https://invent.kde.org/graphics/digikam/-/commit/48009b610643d524aecd4cb7f549dee14fe93014
Comment 9 kde 2025-11-22 23:51:26 UTC
Then again, I'm under the impression that the UX is flawed since it is the node that highlights (which would still be an interesting feature I think) and not the whole tree panel that dims. It could even add some overlay text saying something along the lines of "drop here to add X tags to the Y selected elements." and below that, a list of the selected tags with "+ X-[nb of tags shown] more...".

This way, it would be easy to understand we're not dropping the elements to a specific node.