Bug 421908 - HTML content - mangled generation
Summary: HTML content - mangled generation
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: composereditor-ng (show other bugs)
Version: 5.14.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-22 11:39 UTC by Mario P.
Modified: 2020-05-27 10:04 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.14.2


Attachments
Sample of HTML to build a test-case (2.02 KB, text/html)
2020-05-22 11:39 UTC, Mario P.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mario P. 2020-05-22 11:39:17 UTC
Created attachment 128688 [details]
Sample of HTML to build a test-case

SUMMARY
Signature written in HTML after sending/saving wrongly code by generator

STEPS TO REPRODUCE
1. insert a piece of HTML at "signatures dialog"
2. create a new email (richtext enabled)
3. save as draft and open to display result

OBSERVED RESULT

HTML wrongly generated:
- first 2 lines with a line-break (created by SHIFT+RETURN) are interpreted with a new paragraph and 2nd line showing an extra space in front
- colored lines at end of signature-text inserted - last line showing wrong color

ATTACHMENT
see html-file with source (from signature) and saved result (draft)


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSuSE Tumbleweed 
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1

ADDITIONAL INFORMATION
KDE Applications from Factory: 20.04.1 (built May-20-2020)

most likely a duplicate to bug #358476
Comment 1 Laurent Montel 2020-05-22 12:04:42 UTC
Thanks for test case. I will investigate it soon.
Comment 2 Laurent Montel 2020-05-23 06:57:45 UTC
Git commit 5d4095836ef32e941479133015ae19fc003318ef by Laurent Montel.
Committed on 23/05/2020 at 06:56.
Pushed by mlaurent into branch 'master'.

Start to fix HTML content - mangled generation

M  +1    -1    CMakeLists.txt
M  +1    -0    src/CMakeLists.txt
A  +275  -0    src/grantleebuilder/abstractmarkupbuilder.h     [License: LGPL (v2+)]
M  +2    -1    src/grantleebuilder/autotests/plaintextmarkupbuildertest.cpp
M  +20   -2    src/grantleebuilder/autotests/texthtmlbuildertest.cpp
M  +2    -0    src/grantleebuilder/autotests/texthtmlbuildertest.h
M  +4    -4    src/grantleebuilder/markupdirector.cpp
M  +3    -3    src/grantleebuilder/markupdirector.h
M  +24   -24   src/grantleebuilder/markupdirector_p.h
M  +6    -0    src/grantleebuilder/plaintextmarkupbuilder.cpp
M  +7    -4    src/grantleebuilder/plaintextmarkupbuilder.h
M  +430  -32   src/grantleebuilder/texthtmlbuilder.cpp
M  +197  -3    src/grantleebuilder/texthtmlbuilder.h

https://invent.kde.org/pim/kpimtextedit/commit/5d4095836ef32e941479133015ae19fc003318ef
Comment 3 Laurent Montel 2020-05-23 07:00:19 UTC
Git commit f8dd428f24e7c41a3b01346766ab001b96ce98df by Laurent Montel.
Committed on 23/05/2020 at 06:59.
Pushed by mlaurent into branch 'release/20.04'.

Start to fix HTML content - mangled generation
(cherry picked from commit 5d4095836ef32e941479133015ae19fc003318ef)

M  +1    -0    src/CMakeLists.txt
A  +275  -0    src/grantleebuilder/abstractmarkupbuilder.h     [License: LGPL (v2+)]
M  +2    -1    src/grantleebuilder/autotests/plaintextmarkupbuildertest.cpp
M  +65   -1    src/grantleebuilder/autotests/texthtmlbuildertest.cpp
M  +2    -0    src/grantleebuilder/autotests/texthtmlbuildertest.h
M  +4    -4    src/grantleebuilder/markupdirector.cpp
M  +3    -3    src/grantleebuilder/markupdirector.h
M  +24   -24   src/grantleebuilder/markupdirector_p.h
M  +6    -0    src/grantleebuilder/plaintextmarkupbuilder.cpp
M  +7    -4    src/grantleebuilder/plaintextmarkupbuilder.h
M  +430  -32   src/grantleebuilder/texthtmlbuilder.cpp
M  +197  -3    src/grantleebuilder/texthtmlbuilder.h

https://invent.kde.org/pim/kpimtextedit/commit/f8dd428f24e7c41a3b01346766ab001b96ce98df
Comment 4 Laurent Montel 2020-05-23 07:02:19 UTC
Git commit e884d21c998eabf19d87b13c650ed77ab4bbe16a by Laurent Montel.
Committed on 23/05/2020 at 07:02.
Pushed by mlaurent into branch 'master'.

Fix Start to fix HTML content - mangled generation

M  +1    -1    CMakeLists.txt
M  +0    -1    messagecomposer/src/CMakeLists.txt
M  +3    -4    messagecomposer/src/composer-ng/richtextcomposerng.cpp
M  +0    -1    messageviewer/src/CMakeLists.txt
M  +1    -1    messageviewer/src/messagepartthemes/default/autotests/CMakeLists.txt
M  +2    -1    messageviewer/src/messagepartthemes/default/converthtmltoplaintext.cpp

https://invent.kde.org/pim/messagelib/commit/e884d21c998eabf19d87b13c650ed77ab4bbe16a
Comment 5 Laurent Montel 2020-05-23 07:03:06 UTC
Git commit e0d7ef9b891101961cd4d0d0a36f137fa30334a8 by Laurent Montel.
Committed on 23/05/2020 at 07:02.
Pushed by mlaurent into branch 'release/20.04'.

Fix Start to fix HTML content - mangled generation
(cherry picked from commit e884d21c998eabf19d87b13c650ed77ab4bbe16a)

M  +0    -1    messagecomposer/src/CMakeLists.txt
M  +3    -4    messagecomposer/src/composer-ng/richtextcomposerng.cpp
M  +0    -1    messageviewer/src/CMakeLists.txt
M  +1    -1    messageviewer/src/messagepartthemes/default/autotests/CMakeLists.txt
M  +2    -1    messageviewer/src/messagepartthemes/default/converthtmltoplaintext.cpp

https://invent.kde.org/pim/messagelib/commit/e0d7ef9b891101961cd4d0d0a36f137fa30334a8
Comment 6 Laurent Montel 2020-05-23 10:22:46 UTC
Git commit 8ebf1186705f14fc7f015d12c7d13998afa872b8 by Laurent Montel.
Committed on 23/05/2020 at 10:22.
Pushed by mlaurent into branch 'release/20.04'.

Continue to fix Bug 421908 - HTML content - mangled generation

M  +25   -4    src/grantleebuilder/autotests/texthtmlbuildertest.cpp
M  +1    -0    src/grantleebuilder/autotests/texthtmlbuildertest.h
M  +2    -1    src/grantleebuilder/markupdirector.cpp

https://invent.kde.org/pim/kpimtextedit/commit/8ebf1186705f14fc7f015d12c7d13998afa872b8
Comment 7 Laurent Montel 2020-05-27 10:04:30 UTC
For me it's fixed in 5.14.2