Bug 391287 - kcalutils/autotest fails - kcalutils-testincidenceformatter
Summary: kcalutils/autotest fails - kcalutils-testincidenceformatter
Status: CONFIRMED
Alias: None
Product: kcalutils
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.7.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-02 10:59 UTC by Rik Mills
Modified: 2020-03-08 18:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2018-03-02 10:59:34 UTC
On KDE CI for 17.12 branch and on ubuntu 17.12.2 builds:

https://build.kde.org/job/Applications%20kcalutils%20stable-kf5-qt5%20SUSEQt5.9/16/testReport/(root)/TestSuite/kcalutils_testincidenceformatter/

--- "/home/jenkins/workspace/Applications kcalutils stable-kf5-qt5 SUSEQt5.9/autotests/data/todo-1.html"	2018-02-26 05:53:08.217593608 +0000
+++ "/home/jenkins/workspace/Applications kcalutils stable-kf5-qt5 SUSEQt5.9/autotests/data/todo-1.out.html"	2018-02-26 05:54:10.181642764 +0000
@@ -58,7 +58,7 @@
 <!-- Description -->
       <tr>
         <th valign="top">Description:</th>
-        <td>We need milk <img align="center" title=":)" alt=":)" src="face-smile" width="22" height="22" /></td>
+        <td>We need milk <img align="center" title=":)" alt=":)" src="file:face-smile" width="22" height="22" /></td>
       </tr>
 <!-- Comments -->
 <!-- Reminders -->
FAIL!  : IncidenceFormatterTest::testDisplayViewFormatTodo(todo-1) 'compareHtml(name)' returned FALSE. ()
   Loc: [/home/jenkins/workspace/Applications kcalutils stable-kf5-qt5 SUSEQt5.9/autotests/testincidenceformatter.cpp(319)]
Comment 1 Allen Winter 2018-04-28 15:10:44 UTC
I made a fix that works for me, but jenkins still isn't happy.

must be the locale.  I see the testincidenceformatter uses the LC_ALL=C locale
as in:
set_tests_properties(kcalutils-testincidenceformatter PROPERTIES ENVIRONMENT "LC_ALL=C")

but maybe we need a locale expert and a jenkins person to figure it out.
Comment 2 Rik Mills 2018-08-24 09:30:56 UTC
18.04.3, 18.08.0 and master now also fail with:

https://build.kde.org/job/Applications%20kcalutils%20stable-kf5-qt5%20SUSEQt5.9/38/testReport/(root)/TestSuite/kcalutils_testincidenceformatter/

With respect, it is probably not worth having these test if the test data is not kept up to date.
Comment 3 Andreas Sturmlechner 2020-03-08 18:21:17 UTC
In addition, kcalutils-teststringify fails for me in 19.12.x - can you confirm?
Comment 4 Rik Mills 2020-03-08 18:28:21 UTC
(In reply to andreas.sturmlechner from comment #3)
> In addition, kcalutils-teststringify fails for me in 19.12.x - can you
> confirm?

Afraid not, as Debian and Ubuntu do not yet have 19.12 in respective archives (I plan to work on Ubuntu in next fortnight). Plus we have both dropped the running of PIM autotests, as they were so often broken, and so for us offered little benefit for a high maintenance overhead.