Bug 383294 - Opening updates from system tray makes "settings" and "installed" pages inaccessable
Summary: Opening updates from system tray makes "settings" and "installed" pages inacc...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.10.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-08 20:22 UTC by Matthew Trescott
Modified: 2017-08-11 16:30 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Another (seemingly related) bug (502.85 KB, image/png)
2017-08-10 16:35 UTC, Matthew Trescott
Details
Console output (6.15 KB, text/plain)
2017-08-10 16:36 UTC, Matthew Trescott
Details
Video showcasing issue (1.22 MB, video/mp4)
2017-08-10 20:14 UTC, Matthew Trescott
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Trescott 2017-08-08 20:22:33 UTC
Steps to reproduce:

1. Wait until updates are available
2. Click on the system tray icon and click "Update"
3. Wait a few seconds
4. Attempt to click the "Installed" and/or "Settings" listings in the left-hand menu.

This is an intermittent problem; it showed up for me for several times in a row, then disappeared. :/
Comment 1 Matthew Trescott 2017-08-08 20:29:31 UTC
Another issue which I suppose is related is that when this bug appears, the Update All button is grayed out (unclickable).
Comment 2 Aleix Pol 2017-08-10 15:02:05 UTC
This is a bit weird and cannot reproduce.

Can you try running it from the terminal and see if there's anything relevant going on?

You can run it similarly to how the plasmoid does it by calling:
plasma-discover --mode update

Thanks!
Comment 3 Matthew Trescott 2017-08-10 16:35:58 UTC
Created attachment 107197 [details]
Another (seemingly related) bug
Comment 4 Matthew Trescott 2017-08-10 16:36:40 UTC
Created attachment 107198 [details]
Console output
Comment 5 Matthew Trescott 2017-08-10 16:37:35 UTC
I could consistently reproduce the problem by:

1. Renaming ~/.cache/discover
2. Running plasma-discover --mode update, as you suggested
3. A problem opposite of this bug appears: after you enter the "settings" or "installed" sections, it is impossible to return to "Updates" (though the menu entry remains highlighted---see screenshot)
4. Close Discover and reopen with plasma-discover --mode update
5. The bug appears.

I've also attached the console output from a run where the initial bug appeared.
Comment 6 Aleix Pol 2017-08-10 17:31:18 UTC
Git commit e28b98bb945b1067f64632159c91c2b0113b9c8d by Aleix Pol.
Committed on 10/08/2017 at 17:25.
Pushed by apol into branch 'Plasma/5.10'.

Don't disable the updates action when there are no updates

It's perfectly safe to go in there, it will just show a page saing "no
updates".
Should make this UI a bit more predictable.

M  +1    -1    discover/qml/DiscoverDrawer.qml
M  +1    -2    discover/qml/DiscoverWindow.qml

https://commits.kde.org/discover/e28b98bb945b1067f64632159c91c2b0113b9c8d
Comment 7 Aleix Pol 2017-08-10 17:32:06 UTC
Hi Matthew,
Would you be able to check if this change fixes your issue? If it doesn't please reopen. If so, also a video reproducing the issue would really help.
Comment 8 Matthew Trescott 2017-08-10 20:14:57 UTC
Created attachment 107201 [details]
Video showcasing issue

I compiled the Plasma/5.10 branch and recorded this video showing the issue. Notice that the Update All button is grayed-out at 00:14.
Comment 9 Aleix Pol 2017-08-11 00:36:07 UTC
Super odd. I don't have the issue where "Update All" gets grayed out (we call it disabled ;) ).

I'll look into that tomorrow.
Comment 10 Aleix Pol 2017-08-11 11:48:24 UTC
Git commit 37cfd9b58e3bf1853e03f799e536e30ce755207c by Aleix Pol.
Committed on 11/08/2017 at 11:46.
Pushed by apol into branch 'Plasma/5.10'.

Remove the navigationEnabled concept

We don't need it anymore now that the Updates page can be opened at any
time.
This fixes some quirks found in the mentioned bug report.

M  +0    -1    discover/qml/DiscoverWindow.qml
M  +0    -1    discover/qml/TopLevelPageData.qml
M  +0    -2    discover/qml/UpdatesPage.qml

https://commits.kde.org/discover/37cfd9b58e3bf1853e03f799e536e30ce755207c
Comment 11 Aleix Pol 2017-08-11 11:49:52 UTC
This won't fix the grayed "Update All" button, if it's a notable problem please report it and maybe there's something we can do about it, although it seems like a distro thing...
Comment 12 Matthew Trescott 2017-08-11 15:43:11 UTC
I can usually work around the disabled Update button by browsing the "Applications" section and returning to "Updates."
Comment 13 Aleix Pol 2017-08-11 16:30:58 UTC
Let's move this conversation to: https://bugs.kde.org/show_bug.cgi?id=382228