Bug 380356 - snap backend - library name and location too generic (usr/lib/x86_64-linux-gnu/libSnapClient.so)
Summary: snap backend - library name and location too generic (usr/lib/x86_64-linux-gn...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.10.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-30 14:43 UTC by Rik Mills
Modified: 2017-06-01 00:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2017-05-30 14:43:47 UTC
In ubuntu, library installed to usr/lib/x86_64-linux-gnu/libSnapClient.so)

(or equivalent on other architectures.

As highlighted by ubuntu archive admins, and discussed on #plasma on IRC:

Quote: Archive Admins

 "it is worryingly generic given its location"
 "plasma internal library but seems not plasma named or in a plasma place"

Quote: Jonathan Riddell

 "yes I agree it should be in a sub-directory"

This has been accepted into artful development release, on the condition that it is sorted in the next package upload of discover.
Comment 1 Aleix Pol 2017-05-31 23:58:06 UTC
Good point. Will change the name.

FWIW, I'd recommend not to ship it. It's not ready (that's why it's disabled).
Comment 2 Aleix Pol 2017-06-01 00:02:38 UTC
Git commit d3975092b9ea9aab00bf194bcf0820bbff5050a8 by Aleix Pol.
Committed on 31/05/2017 at 23:59.
Pushed by apol into branch 'Plasma/5.10'.

Rename the generic snap library to DiscoverSnapClient

Hopefully makes Ubuntu happy :)

M  +1    -1    libdiscover/backends/SnapBackend/CMakeLists.txt
M  +4    -4    libdiscover/backends/SnapBackend/libsnapclient/CMakeLists.txt
M  +1    -1    libdiscover/backends/SnapBackend/tests/CMakeLists.txt

https://commits.kde.org/discover/d3975092b9ea9aab00bf194bcf0820bbff5050a8