Bug 377008 - Breeze scrollbar width with Firefox (version >= 52) broken (too wide)
Summary: Breeze scrollbar width with Firefox (version >= 52) broken (too wide)
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.9.2
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: scionicspectre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 09:24 UTC by Rik Mills
Modified: 2017-05-27 21:09 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.7


Attachments
ugly ugly scrollbars (108.45 KB, image/png)
2017-02-28 09:24 UTC, Rik Mills
Details
mitigate breakage by disabling stepper (2.41 KB, patch)
2017-03-21 12:43 UTC, Rik Mills
Details
Firefox scrollbars with above patch (72.14 KB, image/png)
2017-03-21 12:44 UTC, Rik Mills
Details
scrollbar with weird border (61.70 KB, image/png)
2017-03-22 10:04 UTC, Robert Riemann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rik Mills 2017-02-28 09:24:58 UTC
Created attachment 104265 [details]
ugly ugly scrollbars

Affects scrollbars on Firefox 52 beta, 53 developer & 54 nightly.

Wide unsightly scrollbars. Breaks good KDE theme integration on a very front facing browser that is still the default choice in many KDE platforms.

Screenshot attached:

Firefox 52 is due to exit beta and be released on 2017-03-07, so very soon users upgrading their Firefox and who are using affected distos/GTK versions will start hitting this unsightly bug.

Confirmed on, but not limited to:

- kubuntu zesty 17.04 -  GTK 3.22.7
- kubuntu yakkety 16.10 - GTK 3.20.9

&

- chakra latest packages - GTK 3.20.6

Unaffected:

- Neon developer edition - GTK 3.18.9
Comment 1 Rik Mills 2017-03-02 09:21:56 UTC
I have report this also with mozilla.

https://bugzilla.mozilla.org/show_bug.cgi?id=1343802
Comment 2 Patrick Silva 2017-03-06 23:16:21 UTC
I updated to Firefox 52 on Arch today and I can confirm this bug.
Comment 3 Rik Mills 2017-03-21 12:43:32 UTC
Created attachment 104667 [details]
mitigate breakage by disabling stepper

Mitigates the breakage on GTK3 >= 3.20, and actually brings the scrollbar appearance a bit closer to the native Qt Breeze scrollbar appearance in latest releases.

Probably not an ideal solution, and/or could do with tidying up, but oddly I actually prefer this somewhat. May also be superfluous or unwanted if mozilla in the end fix  Gecko their end, but timeline for that is unsure.

Suggested improvements welcome.
Comment 4 Rik Mills 2017-03-21 12:44:50 UTC
Created attachment 104668 [details]
Firefox scrollbars with above patch

Firefox scrollbars with above patch
Comment 5 Robert Riemann 2017-03-22 10:04:08 UTC
Created attachment 104683 [details]
scrollbar with weird border

I have a problem that may be related. My scrollbars have a large gray border.

> firefox --version
Mozilla Firefox 52.0.1

> zypper info MozillaFirefox
Information for package MozillaFirefox:
---------------------------------------
Repository: openSUSE-Leap-42.1-Update
Name: MozillaFirefox
Version: 52.0.1-58.1
Arch: x86_64
Vendor: openSUSE
Installed: Yes
Status: up-to-date
Installed Size: 105.5 MiB
Summary: Mozilla Firefox Web Browser
Comment 6 Elvis Angelaccio 2017-03-22 10:26:58 UTC
@Rik your patch looks good. Can you please submit it to https://phabricator.kde.org/differential/diff/create/ ?
Comment 7 Rik Mills 2017-03-22 11:08:59 UTC
(In reply to Elvis Angelaccio from comment #6)
> @Rik your patch looks good. Can you please submit it to
> https://phabricator.kde.org/differential/diff/create/ ?

Done. :)

https://phabricator.kde.org/D5128
Comment 8 Paul 2017-03-29 02:48:48 UTC
Refer to https://bugzilla.mozilla.org/show_bug.cgi?id=1158076

FF's theme system is currently being re-worked to fix theme issues such as this, in the meantime you can force FF to run with the GTK default internal theme via adding 'GTK_THEME=Adwaita' at the start of the launch command.

Don't know why this isn't marked as confirmed, been an active problem for a very long time now...
Comment 9 Rik Mills 2017-05-12 16:25:10 UTC
Git commit 6ac39e82ff069f6ca4037617d906a695060f5261 by Rik Mills.
Committed on 12/05/2017 at 16:03.
Pushed by rikmills into branch 'Plasma/5.10'.

Set no stepper button for GTK3 scrollbars on gtk >=3.20

Review: https://phabricator.kde.org/D5128

This is a workaround to mitigate broken (huge wide) scrollbars in mozilla/Gecko based applications for GTK3 >= 3.20 in versions 52 onwards.
Ref: https://bugs.kde.org/show_bug.cgi?id=377008 and https://bugzilla.mozilla.org/show_bug.cgi?id=1343802
The mozilla bug is now 'fixed' and landing in nightlies v55, but may continue to affect earlier releases if not brought forward upstream.
Regardless of any other concern, applying this brings the appearance of newer breeze and breeze-gtk scrollars into closer accord.

Differential Revision: D5128

M  +5    -5    Breeze-dark-gtk/gtk-3.20/gtk.css
M  +5    -5    Breeze-gtk/gtk-3.20/gtk.css

https://commits.kde.org/breeze-gtk/6ac39e82ff069f6ca4037617d906a695060f5261
Comment 10 spacemant5010 2017-05-27 20:59:37 UTC
What's the solution for those of us with OpenSUSE 42.2, which is an LTS release and won't get KDE 5.9?  I believe we only get 5.8.x bugfix updates.

Do I need to uninstall the theme?

I'm using FF52ESR which may not get the fix as it was committed for FF55.  I've already nudged them.
Comment 11 Elvis Angelaccio 2017-05-27 21:09:07 UTC
(In reply to javascriptjedi from comment #10)
> What's the solution for those of us with OpenSUSE 42.2, which is an LTS
> release and won't get KDE 5.9?  I believe we only get 5.8.x bugfix updates.
> 
> Do I need to uninstall the theme?
> 
> I'm using FF52ESR which may not get the fix as it was committed for FF55. 
> I've already nudged them.

Fix is in Plasma 5.8.7