Bug 372720 - on rtl langs, when the panel vertical there is visual problems on kickoff
Summary: on rtl langs, when the panel vertical there is visual problems on kickoff
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.8.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-21 07:41 UTC by ttv200
Modified: 2016-11-22 09:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
example (82.60 KB, image/png)
2016-11-21 07:41 UTC, ttv200
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ttv200 2016-11-21 07:41:14 UTC
Created attachment 102357 [details]
example

see attachment

* The tabs need to be on the right
* There is extra padding without reason (also when the panel is not vertical)
Comment 1 Marco Martin 2016-11-21 13:29:44 UTC
about the extra padding circled in green, that's there in ltr as well, i think it's just part of the minimum sizing of kickoff
Comment 2 Kai Uwe Broulik 2016-11-21 13:33:19 UTC
That extra padding is reserved space for the arrow on categories and thus intentional.
Comment 3 Marco Martin 2016-11-21 14:25:34 UTC
https://phabricator.kde.org/D3433
Comment 4 Marco Martin 2016-11-22 09:55:38 UTC
Git commit 460ea235894e1be779eab1f1872bd2858d4d46fa by Marco Martin.
Committed on 22/11/2016 at 09:55.
Pushed by mart into branch 'master'.

tabbar on proper side when ltr

Summary:
when the layout is mirrored, the anchors are too, we end
up on the tabbar anchored to the wrong side, swap left and right states
when the application is mirrored, to keep the tabbar against the panel

Test Plan:
tried with plasmashell both normally and with --reverse parameter
in both cases in vertical panels tabbar is on panel side

Reviewers: #plasma

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3433

M  +2    -5    applets/kickoff/package/contents/ui/FullRepresentation.qml

http://commits.kde.org/plasma-desktop/460ea235894e1be779eab1f1872bd2858d4d46fa