Bug 368894 - device notifier popups do not respect display rules
Summary: device notifier popups do not respect display rules
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices (show other bugs)
Version: 5.7.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-16 11:01 UTC by Harald Sitter
Modified: 2016-09-21 08:51 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.8.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2016-09-16 11:01:10 UTC
devicenotifier applet has a config set to select which type of devices to display. if one adds a loop mount this appers as an event in the applet code

plasmashell(17632)/(default) unknown: "/org/freedesktop/UDisks2/block_devices/loop2" has new interfaces: ("org.freedesktop.UDisks2.Filesystem")
plasmashell(17632)/(qml) onDataChanged: DATA CHANGED

the applet subsequently sets expanded=true ignoring its own display rule. so if the applet was configured to only show removable devices it will trigger a popup of an empty device notifier



Reproducible: Always

Steps to Reproduce:
1. config applet to only show removable devices
2. cause a loop mount (e.g. by installing a snap package)

Actual Results:  
applet pops up persistently but doesn't show the loop device

Expected Results:  
pop up should not appear if the device type is filtered from view
Comment 1 Kai Uwe Broulik 2016-09-21 08:51:04 UTC
Git commit b28ea53b351c9871ecc6ce8a4d3c19806254b9d1 by Kai Uwe Broulik.
Committed on 21/09/2016 at 08:49.
Pushed by broulik into branch 'Plasma/5.8'.

[Device Notifier] Only ever pop up if device is visible in the list

When a device notification arrives, such as "you can now safely unmount" or "failed to unmount"
device notifier would unconditionally open showing an empty list.

Since we now show device notifications only connected to the device they're about, it makes no
sense to expand it for invisible devices. Applications where mounting or unmounting can fail
for non-removable devices, like Dolphin, already show the error message within the UI anyway,
making the popup redundant.
FIXED-IN: 5.8.0

Differential Revision: https://phabricator.kde.org/D2823

M  +18   -7    applets/devicenotifier/package/contents/ui/devicenotifier.qml

http://commits.kde.org/plasma-workspace/b28ea53b351c9871ecc6ce8a4d3c19806254b9d1