Add a tc06_two_races_xml exp output for ppc64. This differs from the existing .exp in that does not contain the pthread_create_WRK entry frame. The non-xml version of this test passes because there is a filter that eliminates the pthread_create_WRK entry from that output. That was introduced in r13983, which added a filter to scrub out pthread_create_WRK from all of the outputs, and updated the .exp files to match. The additional exp file added here covers that same condition for the xml version of this test. I'll note that I did look at the code in and around pthread_create_WRK, in conjunction with the debug and comments from r13983. It looks like the _WRK stack frame is being reused rather than stacked upon. I suspect some part of branch-and-relink-to-noredir is not behaving quite as expected. That said, this rather simple update to the exp is sufficient and is not hiding anything I think is critical... Reproducible: Always
Created attachment 100975 [details] Add tc06_two_races_xml.exp output for ppc64. The attached patch was submitted by Will Schmidt. I have reviewed and tested the patch. The patch fixes the helgrind/tests/tc06_two_races_xml test case on PPC64 I will post the patch to the developer's email list for additional review.
Adding a specific ppc64 file is for sure something that makes the test pass. However, this means we have (almost) duplicated files to maintain. Wouldn't it be possible to instead write a filter for the xml (similarly to the filter for the text output) that removes the ..._WRK ? If that is reasonably easy, the filter approach is preferrable to a duplicated exp file.
Created attachment 101061 [details] updated and refactored patch Per feedback and commentary, this is a different approach to solving the problem... Update and modify the filter_xml filter to strip out the troublesome frame. And a tweak to the same to suppress the blurb that typically indicates a frame has been skipped. Appears to work OK across the systems I have access to. (a mix of ppc64 and a couple x86 boxes).
(In reply to Will Schmidt from comment #3) > Created attachment 101061 [details] > updated and refactored patch > > Per feedback and commentary, this is a different approach to solving the > problem... > > Update and modify the filter_xml filter to strip out the troublesome frame. > And a tweak to the same to suppress the blurb that typically indicates a > frame has been skipped. > Appears to work OK across the systems I have access to. (a mix of ppc64 and > a couple x86 boxes). That looks good to me. Feel free to commit. Thanks
Patch from Will committed, commit 15956
Verified patch commit is OK using fresh pull of the upstream repository. It checks out fine. Closing