Bug 363615 - Please update tar command to make build reproducible.
Summary: Please update tar command to make build reproducible.
Status: RESOLVED FIXED
Alias: None
Product: kdevplatform
Classification: Developer tools
Component: general (show other bugs)
Version: 1.7.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdevelop-bugs-null
URL: https://bugs.debian.org/cgi-bin/bugre...
Keywords:
: 363616 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-27 23:32 UTC by Scarlett Moore
Modified: 2016-06-21 06:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.7.4


Attachments
Fix tar command patch (916 bytes, patch)
2016-05-27 23:37 UTC, Scarlett Moore
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Scarlett Moore 2016-05-27 23:32:03 UTC
https://reproducible.debian.net/issues/unstable/users_and_groups_in_tarball_issue.html

Reproducible: Always

Steps to Reproduce:
1.build
2. build again
3. compare binaries

Actual Results:  
Cannot reproduce

Expected Results:  
A reproducible build.

https://wiki.debian.org/ReproducibleBuilds
Comment 1 Scarlett Moore 2016-05-27 23:35:53 UTC
*** Bug 363616 has been marked as a duplicate of this bug. ***
Comment 2 Scarlett Moore 2016-05-27 23:37:46 UTC
Created attachment 99225 [details]
Fix tar command patch
Comment 3 Aleix Pol 2016-05-31 10:18:01 UTC
Patch looks good to me
Comment 4 Kevin Funk 2016-05-31 12:28:02 UTC
Why the mode switch? This should be done in Git instead.

@Scarlett: Please use Phabricator next time, reviewing on Bugzilla is tedious.
Comment 5 Scarlett Moore 2016-06-20 22:47:05 UTC
Please see:
https://tests.reproducible-builds.org/debian/issues/unstable/different_due_to_umask_issue.html

I do not understand how doing anything with git will change the outcome of the tar command at build time.

Yeah sorry I will put all future reviews in phab.
Comment 6 Kevin Funk 2016-06-21 06:29:23 UTC
Git commit d7e6e583ff5203fecf3e160b2998bde1a4bf68ae by Kevin Funk, on behalf of Scarlett Clark.
Committed on 21/06/2016 at 06:28.
Pushed by kfunk into branch '1.7'.

Fix tar command for reproducible builds
FIXED-IN: 1.7.4

M  +2    -2    cmake/modules/KDevPlatformMacros.cmake

http://commits.kde.org/kdevplatform/d7e6e583ff5203fecf3e160b2998bde1a4bf68ae