Bug 340398 - Merge features from kcolorchooser
Summary: Merge features from kcolorchooser
Status: RESOLVED FIXED
Alias: None
Product: kdialog
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Brad Hards
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-10-27 13:20 UTC by Christoph Feck
Modified: 2016-10-14 08:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Copied the initial color chooser from kcolorchooser to kdialog (83.73 KB, image/png)
2015-01-16 00:58 UTC, Swapnesh Khare
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2014-10-27 13:20:49 UTC
kcolorchooser is similar to "kdialog --getcolor", with the difference that the initial color can be specified via command line argument, or (if omitted), is taken from clipboard, if it contains a color value.

I think it does not make sense to have a separate application just for these minor differences; kcolorchooser can be dropped.
Comment 1 Swapnesh Khare 2015-01-12 09:39:18 UTC
I'm very new to KDE development and I'm confused on how to proceed with this. I have the kdelibs source code but I dont know how to proceed now. Please tell me how to proceed from here.
Comment 2 Christoph Feck 2015-01-12 09:49:58 UTC
Please read https://techbase.kde.org/Getting_Started and if any questions remain, ask on IRC or on the kde-devel mailing list.

The kdelibs source does not really help you, you need the kdialog source (which is in kde-baseapps), the kcolorchooser source, and the KDE frameworks 5 libraries.
Comment 3 Swapnesh Khare 2015-01-16 00:58:11 UTC
Created attachment 90440 [details]
Copied the initial color chooser from kcolorchooser to kdialog

The parts which were different in the two files were the initial color choosers. So, in kdialog if instead of --default, --color is passed as argument then it would take that argument and if it left blank then it can use the clipboard.
Will this do the job?
Comment 4 Christoph Feck 2015-02-15 12:18:18 UTC
Please do not attach images, but actual patch/diff files.

There are multiple errors in there, which are best discussed on reviewboard, so I suggest to create a review request on https://git.reviewboard.kde.org/ and add the link here.
Comment 5 Deleted User 2016-10-08 22:23:43 UTC
I've opened a review request on this (ancient) bug as a way of dipping my toes into KDE development. Please let me know if I've done anything incorrectly, whether in the code or process.
https://git.reviewboard.kde.org/r/129128/
Comment 6 Christoph Feck 2016-10-14 08:18:01 UTC
Git commit 1349cbb0970677bac48e8a74530f8440a1142d05 by Christoph Feck, on behalf of Eli Green.
Committed on 14/10/2016 at 08:15.
Pushed by cfeck into branch 'master'.

Get default color from clipboard, as in kcolorchooser
REVIEW: 129128

M  +8    -0    kdialog/kdialog.cpp

http://commits.kde.org/kde-baseapps/1349cbb0970677bac48e8a74530f8440a1142d05