Bug 338543 - print-manager-4.14.0 fails to compile with >= CUPS 2.0b1
Summary: print-manager-4.14.0 fails to compile with >= CUPS 2.0b1
Status: RESOLVED FIXED
Alias: None
Product: print-manager
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Exherbo Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Nicoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-25 10:11 UTC by Timo Gurr
Modified: 2014-11-10 18:40 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/print-manager/6cf1695086def9ff129decbf39ef69b6b1f61a7f
Version Fixed In: 4.14.3
Sentry Crash Report:

Attachments
print-manager-4.14.0.log (47.88 KB, text/x-log)
2014-08-25 10:11 UTC, Timo Gurr 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Timo Gurr 2014-08-25 10:11:37 UTC 
[...]
/var/tmp/paludis/build/kde-print-manager-4.14.0/work/print-manager-4.14.0/libkcups/KCupsConnection.cpp:383:29: error: invalid use of incomplete type 'ipp_t {aka struct _ipp_s}'
     if (response && response->request.status.status_code == IPP_OK) {
                             ^
In file included from /usr/include/cups/cups.h:34:0,
                 from /var/tmp/paludis/build/kde-print-manager-4.14.0/work/print-manager-4.14.0/libkcups/KCupsConnection.h:34,
                 from /var/tmp/paludis/build/kde-print-manager-4.14.0/work/print-manager-4.14.0/libkcups/KCupsConnection.cpp:22:
/usr/include/cups/ipp.h:673:16: error: forward declaration of 'ipp_t {aka struct _ipp_s}'
 typedef struct _ipp_s ipp_t;  /**** IPP request/response data ****/
[...]

For the complete error.log please see the attached file (print-manager-4.14.0.log).
Comment 1 Timo Gurr 2014-08-25 10:11:57 UTC 
Created attachment 88414 [details]
print-manager-4.14.0.log
Comment 2 Daniel Nicoletti 2014-08-25 13:32:27 UTC 
Git commit 864153745c2593fd7e6c31fe425f347bd83846fe by Daniel Nicoletti.
Committed on 25/08/2014 at 13:31.
Pushed by dantti into branch 'master'.

Adjust CUPS_VERSION_MAJOR to build for CUPS version greater than 1 (needed now that CUPS 2.0b1 is out)

M  +8    -8    libkcups/KCupsConnection.cpp
M  +3    -3    libkcups/KCupsServer.cpp
M  +8    -8    printer-manager-kcm/PrintKCM.cpp

http://commits.kde.org/print-manager/864153745c2593fd7e6c31fe425f347bd83846fe
Comment 3 Daniel Nicoletti 2014-08-25 20:05:18 UTC 
Git commit 731085d7720e7128ab102ef80383d1bfaea27661 by Daniel Nicoletti.
Committed on 25/08/2014 at 20:04.
Pushed by dantti into branch 'master'.

Fix ifdef's logic to still match 1.6 onwards and 1.6 backwards

M  +8    -8    libkcups/KCupsConnection.cpp
M  +3    -3    libkcups/KCupsServer.cpp
M  +8    -8    printer-manager-kcm/PrintKCM.cpp

http://commits.kde.org/print-manager/731085d7720e7128ab102ef80383d1bfaea27661
Comment 4 Rex Dieter 2014-10-16 19:09:54 UTC 
Git commit dd76bd49ccf83b8ddc219fadd7c75fa470e5ab26 by Rex Dieter, on behalf of Daniel Nicoletti.
Committed on 25/08/2014 at 13:31.
Pushed by rdieter into branch 'KDE/4.14'.

Adjust CUPS_VERSION_MAJOR to build for CUPS version greater than 1 (needed now that CUPS 2.0b1 is out)

M  +8    -8    libkcups/KCupsConnection.cpp
M  +3    -3    libkcups/KCupsServer.cpp
M  +8    -8    printer-manager-kcm/PrintKCM.cpp

http://commits.kde.org/print-manager/dd76bd49ccf83b8ddc219fadd7c75fa470e5ab26
Comment 5 Rex Dieter 2014-10-16 19:09:54 UTC 
Git commit 6cf1695086def9ff129decbf39ef69b6b1f61a7f by Rex Dieter, on behalf of Daniel Nicoletti.
Committed on 25/08/2014 at 20:04.
Pushed by rdieter into branch 'KDE/4.14'.

Fix ifdef's logic to still match 1.6 onwards and 1.6 backwards

M  +8    -8    libkcups/KCupsConnection.cpp
M  +3    -3    libkcups/KCupsServer.cpp
M  +8    -8    printer-manager-kcm/PrintKCM.cpp

http://commits.kde.org/print-manager/6cf1695086def9ff129decbf39ef69b6b1f61a7f