Bug 331616 - crash with gradient-tool : after set the line origin and end point, then release stylus.
Summary: crash with gradient-tool : after set the line origin and end point, then rele...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: 2.8 Beta
Platform: Compiled Sources Linux
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 14:15 UTC by David REVOY
Modified: 2014-03-02 11:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
[ ^ crash log ] (13.80 KB, text/plain)
2014-02-28 14:15 UTC, David REVOY
Details
[ ^ screenrecord of 3min before the crash, webm ] (2.45 MB, video/webm)
2014-02-28 15:17 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2014-02-28 14:15:00 UTC
Created attachment 85357 [details]
[ ^ crash log ]

Hi, another phantom 3 star crash for 2.8 branch  ; it concerns the gradient tool.
The crash happened after I set the line origin and end point, then release stylus.
It was a gradient 'FG to Alpha' with white colors. My layer stack wasn't really complex; but artwork size was over 5K pixels large ; and I drew the gradient line as a diagonal over all the artwork.
Fortunately, auto-save happened just before the crash , and I lost nothing of my work in progress. 

Reproductible: no. I tested. I could even reopen the same file and do the same action without crash.
Comment 1 David REVOY 2014-02-28 15:17:50 UTC
Created attachment 85359 [details]
[ ^ screenrecord of 3min before the crash, webm ]
Comment 2 Halla Rempt 2014-03-02 11:08:50 UTC
Git commit 70dc03c3cf5385d5e1e6f0e87b762d8433e4453e by Boudewijn Rempt.
Committed on 02/03/2014 at 11:07.
Pushed by rempt into branch 'calligra/2.8'.

Serialize access to the progress bar

The only way https://bugs.kde.org/show_bug.cgi?id=331616&list_id=939077
can happen is if two actions try to initialize, and therefore delete,
the progress bar at the same time. So, serialize with a mutex and at
the same time wrap the progress bar in a QPointer so we can be sure
to be able to figure out whether it has been deleted.

M  +8    -2    libs/main/KoMainWindow.cpp

http://commits.kde.org/calligra/70dc03c3cf5385d5e1e6f0e87b762d8433e4453e
Comment 3 Halla Rempt 2014-03-02 11:09:00 UTC
Git commit 3850f38c25f45530718fe401e935c0418ff1af84 by Boudewijn Rempt.
Committed on 02/03/2014 at 11:07.
Pushed by rempt into branch 'master'.

Serialize access to the progress bar

The only way https://bugs.kde.org/show_bug.cgi?id=331616&list_id=939077
can happen is if two actions try to initialize, and therefore delete,
the progress bar at the same time. So, serialize with a mutex and at
the same time wrap the progress bar in a QPointer so we can be sure
to be able to figure out whether it has been deleted.

M  +8    -2    libs/main/KoMainWindow.cpp

http://commits.kde.org/calligra/3850f38c25f45530718fe401e935c0418ff1af84