Bug 328970 - In a new preset, thickness value of hatching options is saved at double its value
Summary: In a new preset, thickness value of hatching options is saved at double its v...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Unclassified
Component: Brush engines (show other bugs)
Version: 2.8 Beta
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-18 16:14 UTC by Michel T Gonzalez
Modified: 2013-12-18 18:37 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel T Gonzalez 2013-12-18 16:14:20 UTC
When creating a new hatched brush preset, there is a problem after saving it.
Setting a "Thickness" value under "hatching options" will work as expected, and drawing with the brush is fine.
But when closing krita and opening it again, choosing the new brush will use load it with a Thickness value double its original setting.
So i.e. saving a hatch preset with a Thickness of 2.0, after reloading Krita it will actually load the preset with a Thickness of 4.0.


Reproducible: Always

Steps to Reproduce:
1. Choose a default hatch brush, i.e. Hatch_diag_s
2. In the brush editor, under Hatching options, change "thickness". Set it to 2.0.
3. Save the preset with a new name.
4. Draw on the canvas, everything works fine.
5. Close krita, then open it again.
6. Choose the preset you just created from the brush list.
7. Note Thickness under Hatching options.
Actual Results:  
The new brush has a Thickness setting of 4.0

Expected Results:  
It should have kept the chosen Thickness value.
Comment 1 Sven Langkamp 2013-12-18 17:31:58 UTC
Git commit a5cc6a1fdcdd11a73fbc0844ef43df64ce5909a8 by Sven Langkamp.
Committed on 18/12/2013 at 17:30.
Pushed by langkamp into branch 'master'.

fix problem with saving thickness in hatching brush after an old preset was loaded and then saved

M  +2    -1    krita/plugins/paintops/hatching/kis_hatching_paintop_settings.cpp

http://commits.kde.org/calligra/a5cc6a1fdcdd11a73fbc0844ef43df64ce5909a8
Comment 2 Halla Rempt 2013-12-18 18:37:57 UTC
Git commit fabf02e200277dc7c3934eea63e169956ca6c521 by Boudewijn Rempt, on behalf of Sven Langkamp.
Committed on 18/12/2013 at 17:30.
Pushed by rempt into branch 'calligra/2.8'.

fix problem with saving thickness in hatching brush after an old preset was loaded and then saved

M  +2    -1    krita/plugins/paintops/hatching/kis_hatching_paintop_settings.cpp

http://commits.kde.org/calligra/fabf02e200277dc7c3934eea63e169956ca6c521