Bug 323486 - Scoring requires a list of five players
Summary: Scoring requires a list of five players
Status: RESOLVED FIXED
Alias: None
Product: kajongg
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Wolfgang Rohdewald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-14 09:39 UTC by ospalh@gmail.com
Modified: 2013-08-14 13:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ospalh@gmail.com 2013-08-14 09:39:03 UTC
With a list of four player at Settings/Players, when clicking Game/Score Manual Game, the error
“Please define four players in |Settings→Players|” pops up.

When there are five players in the list, the pop-up does not appear, and you get the scoring mode.

I saw this with the 4.11 git branch, and with the Fedora 18/kdegames 4.9.4 package.
Comment 1 ospalh@gmail.com 2013-08-14 09:47:54 UTC
It also looks like there is only one player available for the “Login ­- Kajongg” dialog when you start a game rather than try to score one.

Then, when starting the scoring session, in the “Select Four Players - Kajongg” dialog, this play-player is not available. For East, there are only the four remaining players to choose from.
For S, W, N, there are even fewer players to choose from.
Comment 2 Wolfgang Rohdewald 2013-08-14 13:06:00 UTC
Git commit 984713828a8c8937413997ddc0de63ab9b5a1cbf by Wolfgang Rohdewald.
Committed on 14/08/2013 at 13:00.
Pushed by wrohdewald into branch 'KDE/4.11'.

all players in player list can now be used for scoring games

commit 375c76b cleaned the data base structure, removing server name
and password from the player table. Since then, only player id and
name are defined per player, so there is no reason why not all of
them should be usable for scoring games

up to 375c76b, the same player name could appear more than once in the
player table: once for scoring games and once for every game server.
FIXED-IN: 4.11.1

M  +3    -9    src/player.py
M  +5    -5    src/playfield.py

http://commits.kde.org/kajongg/984713828a8c8937413997ddc0de63ab9b5a1cbf
Comment 3 Wolfgang Rohdewald 2013-08-14 13:06:44 UTC
Git commit e06f2998cbad8d5f53a8da9d1af3b86f1e493846 by Wolfgang Rohdewald.
Committed on 14/08/2013 at 13:00.
Pushed by wrohdewald into branch 'master'.

all players in player list can now be used for scoring games

commit 375c76b cleaned the data base structure, removing server name
and password from the player table. Since then, only player id and
name are defined per player, so there is no reason why not all of
them should be usable for scoring games

up to 375c76b, the same player name could appear more than once in the
player table: once for scoring games and once for every game server.
FIXED-IN: 4.11.1

M  +3    -9    src/player.py
M  +5    -5    src/playfield.py

http://commits.kde.org/kajongg/e06f2998cbad8d5f53a8da9d1af3b86f1e493846