Bug 314816 - Apper already gives the notification that the system should be restarted before the updates have finished
Summary: Apper already gives the notification that the system should be restarted befo...
Status: RESOLVED FIXED
Alias: None
Product: apper
Classification: Applications
Component: general (show other bugs)
Version: 0.8.0
Platform: openSUSE Linux
: NOR major
Target Milestone: ---
Assignee: Daniel Nicoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-10 10:43 UTC by Raymond Wooninck
Modified: 2013-06-19 17:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Printscreen of the notification area (44.39 KB, image/jpeg)
2013-02-10 10:46 UTC, Raymond Wooninck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Wooninck 2013-02-10 10:43:50 UTC
Certain packages require a reboot after installation. This works fine and Apper is giving the notification for this. However this happens almost instantly after the actual update is triggered. 

Apper should wait until the actual update is finished and then trigger the Require Restart notification. Otherwise if the user would click the notification, the system would be restarted in the middle of an update. 

I have attached a printscreen from the notification area, where one can see that the restart notification is already active, despite that the update is still running

Reproducible: Always
Comment 1 Raymond Wooninck 2013-02-10 10:46:05 UTC
Created attachment 77087 [details]
Printscreen of the notification area
Comment 2 Kevin Kofler 2013-02-12 05:55:13 UTC
I also noticed this on Fedora 18 (apper-0.8.0-2.fc18).
Comment 3 Daniel Nicoletti 2013-02-13 23:29:13 UTC
I'm preparing a patch to packagekit so we can know the transaction flags and don't show a popup notification when we are just simulating.
For now the only workaround is to prevent the backend from sending such signal when simulating.
Thanks.
Comment 4 Daniel Nicoletti 2013-03-01 21:03:23 UTC
Git commit abd2dbbfc267452d38c974e4685b0ed897d3c95e by Daniel Nicoletti.
Committed on 01/03/2013 at 22:01.
Pushed by dantti into branch 'master'.

We now have information about the flags set in the transaction, which allows to filter some messages and provide a better name for actions, like "Downloading Updates"

M  +10   -7    apperd/TransactionJob.cpp
M  +1    -0    apperd/TransactionJob.h
M  +8    -6    apperd/TransactionWatcher.cpp
M  +21   -1    libapper/PkStrings.cpp
M  +1    -1    libapper/PkStrings.h
M  +1    -1    libapper/PkTransaction.cpp
M  +1    -6    libapper/PkTransactionWidget.cpp
M  +0    -1    libapper/PkTransactionWidget.h

http://commits.kde.org/apper/abd2dbbfc267452d38c974e4685b0ed897d3c95e
Comment 5 Christopher Yeleighton 2013-06-19 17:38:48 UTC
Still present in version 0.8.1