Bug 313240 - Transfers between accounts with different currencies show as income/expense
Summary: Transfers between accounts with different currencies show as income/expense
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-14 14:16 UTC by rogersedgewick
Modified: 2013-01-25 13:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rogersedgewick 2013-01-14 14:16:12 UTC
as above 



Reproducible: Always

Steps to Reproduce:
Add two currencies and update rates
Create two bank accounts with different currencies
Create a transfer between those accounts
View the dashboard and deselect Transfers in context menu
No changes is shown in income/expenditure

Actual Results:  
N/A

Expected Results:  
N/A

Skrooge Version 1.2.0
Using KDE Development Platform 4.8.4 (4.8.4)
Ubuntu 12.04 LTS

further to bug 313069
Comment 1 Stephane MANKOWSKI 2013-01-14 15:31:32 UTC
Hi,

If the 2 operations are not equal (same amount + same unit) than this is not a transfer.
You should have a special icon on the operation (2 arrows + a red minus).
This icon indicates that this is 2 grouped operations but not a real transfer.

You can reopen this incident if you are not satisfied by my answer.

Thank you for using Skrooge.
Comment 2 rogersedgewick 2013-01-14 16:14:14 UTC
Does the recipe supplied produce your expected result?

If it does , how does one achieve my desired result - a inter-currency transfer not showing income/expense?
Comment 3 Stephane MANKOWSKI 2013-01-15 12:36:35 UTC
Hi,

In fact, in Skrooge, an operation is considered as a "transfer" if and only if:
-The operation is in a group of only 2 operations
-None of these operations are in a "Loan" account
-Both operations have the same unit
-The amount of the first operation= - the amount of the second one

I think that the rules are too restrictive and could be modified like this:
-The operation is in a group of only 2 operations
-None of these operations are in a "Loan" account
-Both operations have units of type "Currency"
-The sign of amount of the first operation is the opposite of the sign of the amount of the second one

This should solve your issue.
What do you think about this proposal?
Comment 4 Stephane MANKOWSKI 2013-01-16 21:00:00 UTC
Git commit 09227d31ed9e1ffcd6a8001020b25cd9a7f34d9a by Stephane Mankowski.
Committed on 16/01/2013 at 21:58.
Pushed by smankowski into branch 'Feature'.

M  +1    -0    CHANGELOG
M  +1    -1    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +16   -14   skgbankmodeler/skgdocumentbank.cpp

http://commits.kde.org/skrooge/09227d31ed9e1ffcd6a8001020b25cd9a7f34d9a
Comment 5 rogersedgewick 2013-01-23 10:17:54 UTC
I am not sure that it would because my impression is that income and expense is determined by the total of money in and out of a category or just the sum of transactions in the case of transfers. That is to say I do not understand how this change would produce a different outcome. 

The important thing for me is that I can transfer money between different currency accounts and reconcile those accounts in the local currency and that I am able to do as things stand. My comments are more in relation to  future development.  A transfer is a fundamentally different operation to a standard one, since there is no change in wealth apart from any costs attached to the transfer process.  

I will contact you by email to give you my thoughts and experiences just FYI. Thanks for your response and sorry for my delay in replying
Comment 6 Stephane MANKOWSKI 2013-01-25 13:50:55 UTC
Before 1.5.0:
10 € <==> -65.7 F         is considered as group of operation, this is not a TRANSFER because €<>F
10 IBM <==> -2000€    is considered as group of operation, this is not a TRANSFER because €<>IBM
10 € <==> -10€             is considered as a TRANSFER because €=€ and 10=-(-10)

After 1.5.0:
10 € <==> -65.7 F         is considered as a TRANSFER because € and F are both currencies
10 IBM <==> -2000€    is considered as group of operation, this is not a TRANSFER because IBM is share and € a currency
10 € <==> -10€             is considered as a TRANSFER because are both currencies

The amount is no more used.
Remark, I did an error in previous post by writting: The sign of amount of the first operation is the opposite of the sign of the amount of the second one.