When compiling with the additional compile options -pedantic -Werror=return-type I get a lot of compile errors (> 8000). This is because some macros have an additional semicolon added. This patch will fix this (generated against the current master, when the bug was filed). Reproducible: Always Steps to Reproduce: 1. compile with the described compiler options Actual Results: over 8000 warnings Expected Results: no pedantic warnings
Created attachment 76421 [details] patch for fixing pedantic compiler warnings
Git commit 87fc1f7e2c1a1d89ecd4cff4e229339078e829f3 by Stephane Mankowski. Committed on 12/01/2013 at 19:27. Pushed by smankowski into branch 'Feature'. M +1 -0 CHANGELOG A +2533 -0 fix_pedantic.diff M +1 -1 plugins/generic/skg_advice/skgadviceboardwidget.h M +1 -1 plugins/generic/skg_advice/skgadvicedataengine.h M +2 -2 plugins/generic/skg_advice/skgadviceplugin.h M +1 -1 plugins/generic/skg_advice/skgtipofdayboardwidget.h M +2 -2 plugins/generic/skg_bookmark/skgbookmarkplugin.h M +1 -1 plugins/generic/skg_bookmark/skgbookmarkplugindockwidget.h M +2 -2 plugins/generic/skg_dashboard/skgdashboardplugin.h M +1 -1 plugins/generic/skg_dashboard/skgdashboardpluginwidget.h M +2 -2 plugins/generic/skg_debug/skgdebugplugin.h M +1 -1 plugins/generic/skg_debug/skgdebugpluginwidget.h M +2 -2 plugins/generic/skg_delete/skgdeleteplugin.h M +2 -2 plugins/generic/skg_file/skgfileplugin.h M +2 -2 plugins/generic/skg_highlight/skghighlightplugin.h M +1 -1 plugins/generic/skg_monthly/grantlee_filters/skggrantleefilters.h M +2 -2 plugins/generic/skg_monthly/skgmonthlyplugin.h M +1 -1 plugins/generic/skg_monthly/skgmonthlypluginwidget.h M +2 -2 plugins/generic/skg_print/skgprintplugin.h M +2 -2 plugins/generic/skg_properties/skgpropertiesplugin.h M +1 -1 plugins/generic/skg_properties/skgpropertiesplugindockwidget.h M +2 -2 plugins/generic/skg_selectall/skgselectallplugin.h M +2 -2 plugins/generic/skg_undoredo/skgundoredoplugin.h M +1 -1 plugins/generic/skg_undoredo/skgundoredoplugindockwidget.h M +2 -2 plugins/import/skrooge_import_csv/skgimportplugincsv.h M +2 -2 plugins/import/skrooge_import_gnc/skgimportplugingnc.h M +2 -2 plugins/import/skrooge_import_gsb/skgimportplugingsb.h M +2 -2 plugins/import/skrooge_import_json/skgimportpluginjson.h M +2 -2 plugins/import/skrooge_import_kmy/skgimportpluginkmy.h M +2 -2 plugins/import/skrooge_import_mmb/skgimportpluginmmb.h M +2 -2 plugins/import/skrooge_import_mt940/skgimportpluginmt940.h M +2 -2 plugins/import/skrooge_import_ofx/skgimportpluginofx.h M +2 -2 plugins/import/skrooge_import_qif/skgimportpluginqif.h M +2 -2 plugins/import/skrooge_import_skg/skgimportpluginskg.h M +2 -2 plugins/import/skrooge_import_xhb/skgimportpluginxhb.h M +2 -2 plugins/import/skrooge_import_xml/skgimportpluginxml.h M +1 -1 plugins/skrooge/skrooge_bank/skgaccountboardwidget.h M +2 -2 plugins/skrooge/skrooge_bank/skgbankplugin.h M +1 -1 plugins/skrooge/skrooge_bank/skgbankpluginwidget.h M +1 -1 plugins/skrooge/skrooge_budget/skgbudgetdelegate.h M +2 -2 plugins/skrooge/skrooge_budget/skgbudgetplugin.h M +1 -1 plugins/skrooge/skrooge_budget/skgbudgetpluginwidget.h M +2 -2 plugins/skrooge/skrooge_calculator/skgcalculatorplugin.h M +1 -1 plugins/skrooge/skrooge_calculator/skgcalculatorpluginwidget.h M +1 -1 plugins/skrooge/skrooge_calculator/skginterestboardwidget.h M +2 -2 plugins/skrooge/skrooge_categories/skgcategoriesplugin.cpp M +2 -2 plugins/skrooge/skrooge_categories/skgcategoriesplugin.h M +1 -1 plugins/skrooge/skrooge_categories/skgcategoriespluginwidget.h M +2 -2 plugins/skrooge/skrooge_importexport/skgimportexportplugin.h M +1 -1 plugins/skrooge/skrooge_operation/skgoperationboardwidget.h M +2 -2 plugins/skrooge/skrooge_operation/skgoperationplugin.h M +1 -1 plugins/skrooge/skrooge_operation/skgoperationpluginwidget.h M +1 -1 plugins/skrooge/skrooge_operation/skgsplittabledelegate.h M +2 -2 plugins/skrooge/skrooge_payee/skgpayeeplugin.h M +1 -1 plugins/skrooge/skrooge_payee/skgpayeepluginwidget.h M +1 -1 plugins/skrooge/skrooge_report/skgreportboardwidget.h M +2 -2 plugins/skrooge/skrooge_report/skgreportplugin.h M +1 -1 plugins/skrooge/skrooge_report/skgreportpluginwidget.h M +2 -2 plugins/skrooge/skrooge_scheduled/skgscheduledplugin.h M +1 -1 plugins/skrooge/skrooge_scheduled/skgscheduledpluginwidget.h M +1 -1 plugins/skrooge/skrooge_search/skgalarmboardwidget.h M +2 -2 plugins/skrooge/skrooge_search/skgsearchplugin.h M +2 -2 plugins/skrooge/skrooge_search/skgsearchpluginwidget.h M +2 -2 plugins/skrooge/skrooge_tracker/skgtrackerplugin.h M +1 -1 plugins/skrooge/skrooge_tracker/skgtrackerpluginwidget.h M +1 -1 plugins/skrooge/skrooge_unit/skgunitboardwidget.h M +2 -2 plugins/skrooge/skrooge_unit/skgunitplugin.h M +2 -2 plugins/skrooge/skrooge_unit/skgunitpluginwidget.h M +1 -1 skg_dataengine/skgdataengine.h M +1 -1 skgbankgui/skgbkwidgetcollectiondesignerplugin.h M +1 -1 skgbankgui/skgobjectmodel.h M +1 -1 skgbankgui/skgpredicatcreator.h M +1 -1 skgbankgui/skgpredicatcreatordesignerplugin.h M +1 -1 skgbankgui/skgprocesscreator.h M +1 -1 skgbankgui/skgpropertyeditor.h M +1 -1 skgbankgui/skgquerycreator.h M +1 -1 skgbankgui/skgquerycreatordesignerplugin.h M +1 -1 skgbankgui/skgquerydelegate.h M +1 -1 skgbankgui/skgunitcomboboxdesignerplugin.h M +2 -2 skgbankmodeler/skgaccountobject.h M +1 -1 skgbankmodeler/skgbankobject.h M +1 -1 skgbankmodeler/skgbudgetobject.h M +3 -3 skgbankmodeler/skgbudgetruleobject.h M +1 -1 skgbankmodeler/skgcategoryobject.h M +3 -3 skgbankmodeler/skgdocumentbank.h M +3 -3 skgbankmodeler/skgimportexportmanager.h M +3 -3 skgbankmodeler/skgimportplugin.h M +2 -2 skgbankmodeler/skginterestobject.h M +2 -2 skgbankmodeler/skgoperationobject.h M +1 -1 skgbankmodeler/skgpayeeobject.h M +2 -2 skgbankmodeler/skgrecurrentoperationobject.h M +1 -1 skgbankmodeler/skgreportbank.h M +3 -3 skgbankmodeler/skgruleobject.h M +1 -1 skgbankmodeler/skgsuboperationobject.h M +1 -1 skgbankmodeler/skgtrackerobject.h M +2 -2 skgbankmodeler/skgunitobject.h M +1 -1 skgbankmodeler/skgunitvalueobject.h M +2 -2 skgbasegui/skgcalculatoredit.h M +1 -1 skgbasegui/skgcalculatoreditdesignerplugin.h M +1 -1 skgbasegui/skgcolorbuttondesignerplugin.h M +1 -1 skgbasegui/skgcomboboxdesignerplugin.h M +1 -1 skgbasegui/skgdateedit.h M +1 -1 skgbasegui/skgdateeditdesignerplugin.h M +2 -2 skgbasegui/skgdatepickerpopup.h M +2 -2 skgbasegui/skgfilteredtableview.h M +1 -1 skgbasegui/skgfilteredtableviewdesignerplugin.h M +1 -1 skgbasegui/skggraphicsscene.h M +1 -1 skgbasegui/skggraphicsview.h M +1 -1 skgbasegui/skggraphicsviewdesignerplugin.h M +1 -1 skgbasegui/skghtmlboardwidget.h M +3 -3 skgbasegui/skginterfaceplugin.h M +1 -1 skgbasegui/skglineeditdesignerplugin.h M +1 -1 skgbasegui/skgmainpanel.h M +2 -2 skgbasegui/skgobjectmodelbase.h M +1 -1 skgbasegui/skgprogressbardesignerplugin.h M +5 -5 skgbasegui/skgshow.h M +1 -1 skgbasegui/skgshowdesignerplugin.h M +1 -1 skgbasegui/skgtableviewdesignerplugin.h M +1 -1 skgbasegui/skgtablewidgetdesignerplugin.h M +3 -3 skgbasegui/skgtablewithgraph.h M +1 -1 skgbasegui/skgtablewithgraphdesignerplugin.h M +1 -1 skgbasegui/skgtabpage.h M +1 -1 skgbasegui/skgtabwidgetdesignerplugin.h M +1 -1 skgbasegui/skgtreeview.h M +1 -1 skgbasegui/skgtreeviewdesignerplugin.h M +1 -1 skgbasegui/skgwebview.h M +1 -1 skgbasegui/skgwebviewdesignerplugin.h M +1 -1 skgbasegui/skgwidget.h M +1 -1 skgbasegui/skgwidgetcollectiondesignerplugin.h M +1 -1 skgbasegui/skgwidgetselectordesignerplugin.h M +1 -1 skgbasegui/skgzoomselectordesignerplugin.h M +8 -8 skgbasemodeler/skgadvice.h M +6 -6 skgbasemodeler/skgdocument.h M +9 -9 skgbasemodeler/skgerror.h M +2 -2 skgbasemodeler/skgnamedobject.h M +4 -4 skgbasemodeler/skgnodeobject.h M +6 -6 skgbasemodeler/skgobjectbase.h M +3 -3 skgbasemodeler/skgpropertyobject.h M +1 -1 skgbasemodeler/skgreport.h M +4 -4 skgbasemodeler/skgservices.h M +1 -1 skgbasemodeler/skgtransactionmng.h http://commits.kde.org/skrooge/87fc1f7e2c1a1d89ecd4cff4e229339078e829f3