Bug 311414 - Several issues with Lua syntax highlighting
Summary: Several issues with Lua syntax highlighting
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Unclassified
Component: syntax (show other bugs)
Version: Git
Platform: Archlinux Packages Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-09 14:39 UTC by Davorin Učakar
Modified: 2012-12-09 18:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.10


Attachments
Patch for lua.xml (2.74 KB, patch)
2012-12-09 14:40 UTC, Davorin Učakar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Davorin Učakar 2012-12-09 14:39:12 UTC
KDE 4.9.90 / KatePart 3.7

1. When spell checking is turned on, whole file is checked instead of just strings and comments like in C/C++ code
2. Comma is not highlighted like other symbols.
3. When cursor is on a blank area it has the same colour as it is set for Alerts.

Reproducible: Always




Solution (changes to lua.xml):
1. spellChecking="false" attributes should be added to most of itemDataelements.
2. Add comma to symbols string.
3. "Normal Text" itemData element should be moved to the first place in itemDatas array.
Comment 1 Davorin Učakar 2012-12-09 14:40:01 UTC
Created attachment 75751 [details]
Patch for lua.xml
Comment 2 Dominik Haumann 2012-12-09 18:23:11 UTC
Git commit 657e99ac2a0cb4c129dc7c3d2e475a84c9ac9460 by Dominik Haumann.
Committed on 09/12/2012 at 19:18.
Pushed by dhaumann into branch 'master'.

lua: fix spell checking, and things and suff

Thanks to Davorin Učakar <davorin.ucakar at gmail com> for the patch!
FIXED-IN: 4.10

M  +12   -12   part/syntax/data/lua.xml

http://commits.kde.org/kate/657e99ac2a0cb4c129dc7c3d2e475a84c9ac9460