Bug 311099 - View the underscore when using Ctrl + PagDown
Summary: View the underscore when using Ctrl + PagDown
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: icons mode (show other bugs)
Version: 2.1
Platform: unspecified Other
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-03 18:26 UTC by Francesco Noacco
Modified: 2013-09-12 12:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Noacco 2012-12-03 18:26:34 UTC
The position of the last row of icons and text is slightly too low and hide the focus of the last file (typically happens at the second press).

Reproducible: Always

Steps to Reproduce:
1. Enter a folder with many files
2. select icon view
3. repeatedly press Ctrl + PagDown
Comment 1 Francesco Noacco 2012-12-04 22:17:49 UTC
Version 1.4 (Debian 6) is working properly.
Comment 2 Christoph Feck 2012-12-09 16:41:13 UTC
What is Ctrl+Pg actually supposed to do? On today's master, Ctrl+PgUp/Down seems to not move the selection focus at all. If this is intended, it should actually scroll the view on the first press, not just on the second and later presses.
Comment 3 Christoph Feck 2012-12-09 17:43:34 UTC
Ignore my previous comment, I now tested with Oxygen style.
Comment 4 Emmanuel Pescosta 2013-09-11 19:51:57 UTC
Review-Request: https://git.reviewboard.kde.org/r/112678/
Comment 5 Emmanuel Pescosta 2013-09-12 12:02:01 UTC
Git commit 6566f757afc437d02e182108f0ee7a74d36d6ac5 by Emmanuel Pescosta.
Committed on 12/09/2013 at 11:58.
Pushed by emmanuelp into branch 'KDE/4.11'.

Fix Bug 311099 - View the underscore when using Ctrl + PagDown

Take the style option vertical/horizontal margin into account
for the calculation of the new scroll offset.

Thanks to Frank for pointing out two other problems with "Page Up/Down" and providing
a better way to fix these problems. :)
FIXED-IN: 4.11.2
REVIEW: 112678

M  +5    -1    dolphin/src/kitemviews/kitemlistview.cpp

http://commits.kde.org/kde-baseapps/6566f757afc437d02e182108f0ee7a74d36d6ac5