Bug 307603 - Alt+Enter should open item properties dialog as with Alt+Return
Summary: Alt+Enter should open item properties dialog as with Alt+Return
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 2.1
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2012-09-30 09:39 UTC by Syam
Modified: 2012-10-07 17:40 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.3


Attachments
Fixes the issue described in this bug report. (802 bytes, patch)
2012-10-07 06:22 UTC, Amol Godbole
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Syam 2012-09-30 09:39:27 UTC
The short-cut Alt+Return (i.e. the big 'enter' key on the main keypad) opens the item properties dialog. But hitting Alt+Enter (the key on the numeric keypad) actually opens the item.

These keys are used interchangeably for all purposes I know (except perhaps some games). IMHO there's no reason why Dolphin should be any different. 

Several times, I have accidentally selected a bunch of files selected and hit Alt+Enter and had a plethora of windows opened by Dolhin!

Although this is user configurable, I guess a more sensible default would be to treat these key combinations as equivalent.

Reproducible: Always

Steps to Reproduce:
1. Select a bunch of files/folders
2. Hit Alt+Enter
Actual Results:  
Lots of windows open up - for opening each item.

Expected Results:  
One single property dialog comes up.
Comment 1 Frank Reininghaus 2012-09-30 13:55:56 UTC
Thanks for your report! I agree that this makes sense.
Comment 2 Amol Godbole 2012-10-07 06:22:48 UTC
Created attachment 74382 [details]
Fixes the issue described in this bug report.
Comment 3 Amol Godbole 2012-10-07 06:24:51 UTC
Posted the fix to the review board: 
http://reviewboard.kde.org/r/106753/
Comment 4 Frank Reininghaus 2012-10-07 17:40:30 UTC
Git commit 6497837b2d5df0b4464bf43d7374441301464d3d by Frank Reininghaus, on behalf of Amol Godbole.
Committed on 07/10/2012 at 19:37.
Pushed by freininghaus into branch 'KDE/4.9'.

Use not only Alt+Return, but also Alt+Enter as shortcut for "Properties"
REVIEW: 106753
FIXED-IN: 4.9.3

M  +1    -1    dolphin/src/views/dolphinviewactionhandler.cpp

http://commits.kde.org/kde-baseapps/6497837b2d5df0b4464bf43d7374441301464d3d