Bug 305400 - Kate desktop-file breaks session restore by using -b (blocking) option
Summary: Kate desktop-file breaks session restore by using -b (blocking) option
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-18 17:24 UTC by Evstifeev Roman
Modified: 2012-10-28 17:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evstifeev Roman 2012-08-18 17:24:56 UTC
Default Kate .desktop-file uses --block option in command line, which leads to opening multiple kate processes and breaks KDE session restore when it tries to restore all of them.

With --block option, opening every new file with kate leads to creation new kate process in the background. If user opened a lot of files, and then logout\login, KDE session restore will open that many kate windows, and session data (like enabled plugins) will be lost (bug https://bugs.kde.org/show_bug.cgi?id=156330)

To fix this temporarily user must change kate command line by hand. But this will lead to bug https://bugs.kde.org/show_bug.cgi?id=286717 - kate will loose it's ability to handle remote file with KIO properly.

To fix this in the code default kate desktop-file should not contain "-b" option.

Reproducible: Always
Comment 1 steveren 2012-10-16 10:17:31 UTC
It's bugged me for ages, this one.
Comment 2 Christoph Cullmann 2012-10-28 15:55:36 UTC
Git commit 5e8e200e3b6a68d81bf43ae7be777c12ed09995e by Christoph Cullmann.
Committed on 28/10/2012 at 16:54.
Pushed by cullmann into branch 'master'.

try it without -b to fix session restore
I think it was added to fix other problems with opening files in dolphin, but lets see

M  +1    -1    kate/data/kate.desktop

http://commits.kde.org/kate/5e8e200e3b6a68d81bf43ae7be777c12ed09995e
Comment 3 Christoph Cullmann 2012-10-28 16:01:49 UTC
Git commit d3ff8955b85bbfe398eec3f4e64f73280a83e5fd by Christoph Cullmann.
Committed on 28/10/2012 at 17:01.
Pushed by cullmann into branch 'master'.

even better fix: ignore -b on session restore

M  +4    -0    kate/app/katemain.cpp
M  +1    -1    kate/data/kate.desktop

http://commits.kde.org/kate/d3ff8955b85bbfe398eec3f4e64f73280a83e5fd
Comment 4 Christoph Cullmann 2012-10-28 17:25:25 UTC
Git commit ca124292abac05cd601345e1d1e09eeee845f972 by Christoph Cullmann.
Committed on 28/10/2012 at 18:24.
Pushed by cullmann into branch 'master'.

even better fix: no session restore for pure clients

M  +3    -4    kate/app/katemain.cpp

http://commits.kde.org/kate/ca124292abac05cd601345e1d1e09eeee845f972