304427 – Half-star ratings in the view are rendered wrong

Bug 304427 - Half-star ratings in the view are rendered wrong

Summary: Half-star ratings in the view are rendered wrong

Status:	RESOLVED FIXED

Alias:	None

Product:	kdelibs
Classification:	Frameworks and Libraries
Component:	kdeui (show other bugs)
Version:	4.9.1
Platform:	openSUSE Linux

Importance:	NOR minor
Target Milestone:	---
Assignee:	kdelibs bugs

URL:
Keywords:	reproducible

Depends on:
Blocks:

Reported:	2012-08-02 09:42 UTC by Daniel Faust
Modified:	2012-09-23 18:55 UTC (History)
CC List:	2 users (show)

See Also:
Latest Commit:	http://commits.kde.org/kdelibs/a24fdb5e0ab630623d6cf4ee6f41bc413a8b4e5a
Version Fixed In:	4.9.2

Attachments
Screenshow showing that the half star is rendered with the yellow part on the right side (3.91 KB, image/png) 2012-08-02 09:43 UTC, Daniel Faust	Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Faust 2012-08-02 09:42:20 UTC

Stars that represent half a rating point are rendered with the yellow part on the right side, instead of the left.

Reproducible: Always

Steps to Reproduce:
1. Use adjust view properties -> additional information -> check ratings in order to enable the display of ratings in the file view

Actual Results:  
Half stars are rendered with the yellow part on the right side.

Expected Results:  
Half stars should be rendered with the yellow part on the left side.

Comment 1 Daniel Faust 2012-08-02 09:43:33 UTC

Created attachment 72889 [details]
Screenshow showing that the half star is rendered with the yellow part on the right side

Comment 2 Frank Reininghaus 2012-08-06 09:38:35 UTC

Thanks for the bug report! I can confirm this issue.

Comment 3 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:29 UTC

Resetting assignee to default as per bug #305719

Comment 4 Christoph Feck 2012-09-23 17:11:08 UTC

Git commit a24fdb5e0ab630623d6cf4ee6f41bc413a8b4e5a by Christoph Feck.
Committed on 23/09/2012 at 19:05.
Pushed by cfeck into branch 'KDE/4.9'.

Fix "half-stars" rendering in KRatingPainter

When the application has not specified a layout direction,
QPainter defaults to Qt::LayoutDirectionAuto. Assume LTR
in this case.
FIXED-IN: 4.9.2

M  +4    -4    kdeui/widgets/kratingpainter.cpp

http://commits.kde.org/kdelibs/a24fdb5e0ab630623d6cf4ee6f41bc413a8b4e5a

Comment 5 Frank Reininghaus 2012-09-23 18:55:48 UTC

Thanks for you awesome work, Christoph!