Bug 299579 - kdesrc-build self check fails
Summary: kdesrc-build self check fails
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-07 18:33 UTC by Gregor Tätzner
Modified: 2012-05-10 02:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.15.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregor Tätzner 2012-05-07 18:33:03 UTC
Hello, test number 3 returns 0. Are there some prerequisites I'm missing?

Reproducible: Always

Steps to Reproduce:
1. run kdesrc-buid-test.pl

Actual Results:  
./kdesrc-build-test.pl 
kdesrc-build being run from testing framework, BRING IT.
kdesrc-build is version 1.15
ok 1 - Ensure BuildContext classiness isa ksb::BuildContext
ok 2 - Ensure PhaseList classiness isa ksb::PhaseList
not ok 3 - Correct number of items from filter_program_output
#   Failed test 'Correct number of items from filter_program_output'
#   at ./kdesrc-build-test.pl line 105.
#          got: '0'
#     expected: '1'
fatal: Not a git repository (or any parent up to mount parent )
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
ok 4 - Ensure filter_program_output works w/ no filter
ok 5 - Correct tilde-expansion for source-dir
ok 6 - unique_list
ok 7 - correct log dir for test run
ok 8 - qt cxxflags handling
ok 9 - qt configure-flags handling
ok 10 - Test normal sticky option
ok 11 - kdelibs cmake-options appending
ok 12 - kdelibs options appending
ok 13 - get_option limit to module level
ok 14 - KDE module trunk
ok 15 - KDE module tag preferred to branch
ok 16 - KDE module branch
ok 17 # skip svn not installed
Installing KDE SSL signature for Subversion.  This is to avoid
Subversion warnings about KDE's self-signed SSL certificate for svn.kde.org
ok 18 - Verify KDE SVN server SSL signature can be installed
ok 19 - Verify installed KDE SVN SSL certificate is correct
ok 20 - non-KDE module trunk
ok 21 - kdesupport-for-$foo with local branch override
ok 22 - non-KDE module tag (no name appended)
ok 23 - non-KDE module tag (no name; entire URL)
ok 24 - non-KDE module branch (no name appended)
ok 25 - module-base-path
ok 26 - split_quoted_on_whitespace quotes and spaces
ok 27 - split_quoted_on_whitespace space, no quotes
ok 28 - split_quoted_on_whitespace space no quotes, leading whitespace
ok 29 - split_quoted_on_whitespace space no quotes, trailing whitespace
ok 30 - split_quoted_on_whitespace space no quotes, leading and trailing whitespace
ok 31 - split_quoted_on_whitespace with braces/quotes
ok 32 # skip svn not available or network was down
ok 33 # skip svn not available or network was down
ok 34 - build-dir subdir path rel
ok 35 - log-dir subdir path rel
ok 36 - build-dir subdir path abs
ok 37 - build-dir subdir path abs and tilde expansion
ok 38 - creating temp file
ok 39 - correct playground/libs log path
ok 40 - separate source-dir for modules
ok 41 - setting global set-env for modules
ok 42 - setting module set-env for modules
ok 43 - prependEnvironmentValue queues value
ok 44 - prependEnvironmentValue queues in right order
ok 45 - prependEnvironmentValue queues multiple times
ok 46 - prependEnvironmentValue initial value
ok 47 - svn_module_url prefer module specific to global
ok 48 - testing override-url
ok 49 - testing process_arguments module options
ok 50 - testing process_arguments return value for no passed module names
ok 51 - Ensure objects not modified through references to them
ok 52 - testing process_arguments return value for passed module names
ok 53 - testing --no-src phase updating
ok 54 - Build context also not updating
ok 55 - updateModulePhases only for modules
ok 56 - identical objects are identical
ok 57 - Make sure run-tests is recognized for a module
ok 58 - run-tests not set for kdebase
ok 59 - Make sure run-tests is recognized only for its module
ok 60 - testing --no-build phase updating
ok 61 - Build context also not building
ok 62 - testing --no-src and --no-build phase updating
ok 63 - Build context also not building or updating
ok 64 - read_options/parse_module
ok 65 - git-repository-base
ok 66 - Ensure repository gives git scm (part 1)
ok 67 - manual-build for kde-projects submodule (Bug 288611)
ok 68 - Ensure repository gives git scm (part 2)
ok 69 - Qt build systems load right.
ok 70 - read_options module reading
ok 71 - resume-from under module-set
ok 72 - resume-from under module-set, not first module in set
ok 73 - resume-from a module-set
You specified both --resume-from and --resume-after but you can only
use one.

ok 74 - resume-{from,after} combine for exception isa BuildException
ok 75 - resume-after a module-set
ok 76 - Ensure build dir does not exist
ok 77 - Make temp build directory
ok 78 - Double-check temp build dir created
ok 79 - Successful return of log_command
ok 80 - log_command actually calls callback
ok 81 - Test undef was passed at end of execution
ok 82 - Verify LC_MESSAGES set if no_translate used
ok 83 - Verify LC_ALL stripped if no_translate used
ok 84 - generic-build isSubdirBuildable
ok 85 - Ensure createBuildSystem can be called
        Removing files in build directory for test-module
        Old build system cleaned, starting new build system.
ok 86 - Ensure cleanBuildSystem can be called
ok 87 - l10n-build isSubdirBuildable-scripts
ok 88 - l10n-build isSubdirBuildable-other
1..88
The full test suite was not run. To do so, pass --full-run when running the tests
# Looks like you failed 1 test of 88.
[greg@greg-desktop kdesrc-build-1.15]$ ./kdesrc-build-test.pl --full-run
kdesrc-build being run from testing framework, BRING IT.
kdesrc-build is version 1.15
ok 1 - Ensure BuildContext classiness isa ksb::BuildContext
ok 2 - Ensure PhaseList classiness isa ksb::PhaseList
not ok 3 - Correct number of items from filter_program_output
#   Failed test 'Correct number of items from filter_program_output'
#   at ./kdesrc-build-test.pl line 105.
#          got: '0'
#     expected: '1'
fatal: Not a git repository (or any parent up to mount parent )
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
ok 4 - Ensure filter_program_output works w/ no filter
ok 5 - Correct tilde-expansion for source-dir
ok 6 - unique_list
ok 7 - correct log dir for test run
ok 8 - qt cxxflags handling
ok 9 - qt configure-flags handling
ok 10 - Test normal sticky option
ok 11 - kdelibs cmake-options appending
ok 12 - kdelibs options appending
ok 13 - get_option limit to module level
ok 14 - KDE module trunk
ok 15 - KDE module tag preferred to branch
ok 16 - KDE module branch
 U   /tmp/kdesrc-build-test-H9onvc/kdesupport
Checked out revision 1293420.
ok 17 - Make empty subversion checkout.
Installing KDE SSL signature for Subversion.  This is to avoid
Subversion warnings about KDE's self-signed SSL certificate for svn.kde.org
ok 18 - Verify KDE SVN server SSL signature can be installed
ok 19 - Verify installed KDE SVN SSL certificate is correct
ok 20 - non-KDE module trunk
ok 21 - kdesupport-for-$foo with local branch override
ok 22 - non-KDE module tag (no name appended)
ok 23 - non-KDE module tag (no name; entire URL)
ok 24 - non-KDE module branch (no name appended)
ok 25 - module-base-path
ok 26 - split_quoted_on_whitespace quotes and spaces
ok 27 - split_quoted_on_whitespace space, no quotes
ok 28 - split_quoted_on_whitespace space no quotes, leading whitespace
ok 29 - split_quoted_on_whitespace space no quotes, trailing whitespace
ok 30 - split_quoted_on_whitespace space no quotes, leading and trailing whitespace
ok 31 - split_quoted_on_whitespace with braces/quotes
ok 32 - svn requirement detection
ok 33 - svn-info output (url)
ok 34 - svn-info output (revision)
ok 35 - build-dir subdir path rel
ok 36 - log-dir subdir path rel
ok 37 - build-dir subdir path abs
ok 38 - build-dir subdir path abs and tilde expansion
ok 39 - creating temp file
ok 40 - correct playground/libs log path
ok 41 - separate source-dir for modules
ok 42 - setting global set-env for modules
ok 43 - setting module set-env for modules
ok 44 - prependEnvironmentValue queues value
ok 45 - prependEnvironmentValue queues in right order
ok 46 - prependEnvironmentValue queues multiple times
ok 47 - prependEnvironmentValue initial value
ok 48 - svn_module_url prefer module specific to global
ok 49 - testing override-url
ok 50 - testing process_arguments module options
ok 51 - testing process_arguments return value for no passed module names
ok 52 - Ensure objects not modified through references to them
ok 53 - testing process_arguments return value for passed module names
ok 54 - testing --no-src phase updating
ok 55 - Build context also not updating
ok 56 - updateModulePhases only for modules
ok 57 - identical objects are identical
ok 58 - Make sure run-tests is recognized for a module
ok 59 - run-tests not set for kdebase
ok 60 - Make sure run-tests is recognized only for its module
ok 61 - testing --no-build phase updating
ok 62 - Build context also not building
ok 63 - testing --no-src and --no-build phase updating
ok 64 - Build context also not building or updating
ok 65 - read_options/parse_module
ok 66 - git-repository-base
ok 67 - Ensure repository gives git scm (part 1)
ok 68 - manual-build for kde-projects submodule (Bug 288611)
ok 69 - Ensure repository gives git scm (part 2)
ok 70 - Qt build systems load right.
ok 71 - read_options module reading
ok 72 - resume-from under module-set
ok 73 - resume-from under module-set, not first module in set
ok 74 - resume-from a module-set
You specified both --resume-from and --resume-after but you can only
use one.

ok 75 - resume-{from,after} combine for exception isa BuildException
ok 76 - resume-after a module-set
ok 77 - Ensure build dir does not exist
ok 78 - Make temp build directory
ok 79 - Double-check temp build dir created
ok 80 - Successful return of log_command
ok 81 - log_command actually calls callback
ok 82 - Test undef was passed at end of execution
ok 83 - Verify LC_MESSAGES set if no_translate used
ok 84 - Verify LC_ALL stripped if no_translate used
ok 85 - generic-build isSubdirBuildable
ok 86 - Ensure createBuildSystem can be called
        Removing files in build directory for test-module
        Old build system cleaned, starting new build system.
ok 87 - Ensure cleanBuildSystem can be called
ok 88 - l10n-build isSubdirBuildable-scripts
ok 89 - l10n-build isSubdirBuildable-other
1..89
# Looks like you failed 1 test of 89.
Comment 1 Michael Pyne 2012-05-08 01:30:31 UTC
Sorry, this is an artifact of the test suite normally being run under a git-managed source directory. The test suite should perform a git-init or similar in the temporary directory first.
Comment 2 Michael Pyne 2012-05-10 02:23:27 UTC
Git commit 5a01d0d19d620614bfffb0dd9797657f8d57206f by Michael Pyne.
Committed on 10/05/2012 at 03:37.
Pushed by mpyne into branch 'master'.

Run test suite from temporary test directory.

A couple of git tests were passing when the test suite was run from a
git checkout and failing when not. This was due to an underlying
errorneous assumption.

This commit fixes that assumption by making a new
git checkout, and also changes to the temporary directory setup for the
test at the start to hopefully prevent other tests from passing when
they shouldn't.
FIXED-IN:1.15.1

M  +10   -0    kdesrc-build-test.pl

http://commits.kde.org/kdesrc-build/5a01d0d19d620614bfffb0dd9797657f8d57206f