Bug 294347 - kdesrc-build appends origin-$branch
Summary: kdesrc-build appends origin-$branch
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-18 10:51 UTC by Giorgos Tsiapaliokas
Modified: 2012-04-30 02:23 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 1.15


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Giorgos Tsiapaliokas 2012-02-18 10:51:19 UTC
Version:           unspecified (using KDE 4.8.0) 
OS:                Linux

Hello,

kdesrc-build appends origin-$branch during the checkout.
It shouldn't since we want to keep the original names of the branch

Reproducible: Always

Steps to Reproduce:
sth

Actual Results:  
sth

Expected Results:  
sth
Comment 1 Michael Pyne 2012-03-05 02:27:58 UTC
The current behavior is to try and avoid stamping on existing branch names. With that in mind I don't mind changing to have the local branch name match the remote branch name if there isn't a local branch already, but I would have to look into how best to check for that. ;)
Comment 2 Giorgos Tsiapaliokas 2012-03-05 07:26:38 UTC
(In reply to comment #1)
> The current behavior is to try and avoid stamping on existing branch names.
> With that in mind I don't mind changing to have the local branch name match
> the remote branch name if there isn't a local branch already, but I would
> have to look into how best to check for that. ;)

I see your point. Maybe you could add an option for both.
Comment 3 Michael Pyne 2012-04-30 02:23:37 UTC
Git commit 767942ff729e29cd9515e859ed080017c20e5321 by Michael Pyne.
Committed on 30/04/2012 at 04:17.
Pushed by mpyne into branch 'master'.

Use remote branch name for local branch if possible.

When setting up a local remote-tracking branch (either on clone or when
the user chooses a different branch in the rc file), kdesrc-build has
preferred a '$remoteName-$branchName' naming convention to try to avoid
stepping on user's existing branches.

In reality most users do not use local branches, and those that do would
(according to feedback I've received) prefer the local and remote branch
names to be the same as per git practice basically everywhere.

Since it's easy enough to check that the local branch doesn't already
exist before creating it, just do that and drop the remote name from the
created branch name.
FIXED-IN:1.15

M  +17   -11   kdesrc-build

http://commits.kde.org/kdesrc-build/767942ff729e29cd9515e859ed080017c20e5321