Bug 284396 - kickoff icon doesn't resize with the panel
Summary: kickoff icon doesn't resize with the panel
Status: RESOLVED WORKSFORME
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-kickoff (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Rick Stockton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 18:30 UTC by Victor Gavrish
Modified: 2012-04-11 06:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
How it looks. (4.12 KB, image/png)
2011-10-18 18:31 UTC, Victor Gavrish
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Gavrish 2011-10-18 18:30:31 UTC
Version:           unspecified (using KDE 4.7.2) 
OS:                Linux

If you prefer a bigger panel, everything resizes fine (the clock, the tray and the taskbar) except for the kickoff menu icon. It remains the same size and acquires margins on the top and bottom size. 

Reproducible: Always

Steps to Reproduce:
Resize the panel to twice the size.

Actual Results:  
The kickoff icon doesn't resize.

Expected Results:  
The kickoff icon should resize.
Comment 1 Victor Gavrish 2011-10-18 18:31:19 UTC
Created attachment 64680 [details]
How it looks.
Comment 2 Rick Stockton 2012-04-09 07:03:16 UTC
Victor, your attachment shows one of the two the default images, "start-here-kde.png". (The other one, an arrow to the right, is named "start-here.png".

Since ArchLinux is a Rolling-Release distro, can you retry with 4.8 (preferrably, 4.8.1) ?
I haven't seen a problem in either of my Distros (Magaeia "beta-2", and now Fedora 17 Beta RC3+). I'll do a Git blame on the KDE code, but the fix might at a lower level (within Qt.)

I'll write another comment in 10-12 hours.
Comment 3 Rick Stockton 2012-04-09 07:23:58 UTC
Victor, does your /usr/share/icons containa full set of sizes, like this:

file:///usr/share/icons/default.kde4/22x22/places/start-here-kde.png
file:///usr/share/icons/default.kde4/64x64/places/start-here-kde.png
file:///usr/share/icons/default.kde4/256x256/places/start-here-kde.png
file:///usr/share/icons/default.kde4/32x32/places/start-here-kde.png
file:///usr/share/icons/default.kde4/16x16/places/start-here-kde.png
file:///usr/share/icons/default.kde4/48x48/places/start-here-kde.png
file:///usr/share/icons/default.kde4/128x128/places/start-here-kde.png
Comment 4 Victor Gavrish 2012-04-10 02:44:16 UTC
Yes, this bug no longer affects me in KDE 4.8.
Comment 5 Rick Stockton 2012-04-11 06:32:05 UTC
Per reporter (Victor, on Arch Linux) and myself (On Mageia-Beta-2 and Fedora 17 Beta-RC-3), this bug is Resolved in the subsequent KDE Minor Version (4.8.x).

-- following is a guess about the cause --

I don't see a code change in the relevant routines ( plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp, and etc.) which would have made behavior change subsequent to 2010. But, the "start-here-kde" icon set probably needs to have multiple .png copies- with each larger version exceeding the size of the smaller version by a factor of two or less. This allows for smoother resizing and reduced graininess, but the maximum increase which a given icon may be given is (I'm guessing here) limited by this line:

resize(IconSize(KIconLoader::Desktop) * 2, IconSize(KIconLoader::Desktop) * 2);

If I'm right, then the Arch problem probably occured as a result of packaging without the full set of icons shown in comment 3. But even my my theory is wrong, this bug is definitely Resolved/Works for me in 4.8.

I'll re-open if it occurs with KDE 4.8.1 or later. If you've got it, then please advise (in your subsequent comment) whether your installation provides "the full set of sizes" which I listed for "start-here-here-kde.png" which I listed in comment 3.