Bug 283600 - android: port vgdb.c
Summary: android: port vgdb.c
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.7 SVN
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-08 13:57 UTC by Philippe Waroquiers
Modified: 2011-10-22 20:43 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
port vgdb.c to android (11.67 KB, text/plain)
2011-10-08 13:57 UTC, Philippe Waroquiers
Details
port vgdb.c to android (12.23 KB, text/plain)
2011-10-09 19:59 UTC, Philippe Waroquiers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Waroquiers 2011-10-08 13:57:03 UTC
Created attachment 64337 [details]
port vgdb.c to android

Port vgdb.c to Android.
Regression tested on f12/x86, deb5/amd64, RHEL4/s390x
Manually and minimally tested GDB+vgdb on an Android emulator.

Changes in vgdb.c:
* conditionalized some include files on VGPV_arm_linux_android
* undefined PTRACEINVOKER for android
* ignore usleep return value
* changed locking from posix locking (not available on android)
  to fcntl locking
* implemented --port= option to vgdb. This allows to use
  tcp/ip between GDB and vgdb (allowing to debug an android
  valgrind from a development machine where android NDK is installed)
* conditionalized call to pthread_cancel (not available on android,
  and only needed if PTRACEINVOKER is set)

Changes in docs/xml/manual-core-adv.xml:
* documented the --port= new vgdb option
* documented the way to connect from Android NDK gdb to
  Valgrind gdbserver on an android system
* documented no ptraceinvoker on Android
Comment 1 Philippe Waroquiers 2011-10-09 19:59:31 UTC
Created attachment 64372 [details]
port vgdb.c to android

Same as before +
* m_options.c : removes the #ifdef android setting clo_vgdb to no
Comment 2 Julian Seward 2011-10-22 20:43:11 UTC
Committed, r12204.  Thanks.