Bug 282133 - clearButton does not work when input text specifies value attribute
Summary: clearButton does not work when input text specifies value attribute
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml forms (show other bugs)
Version: Git
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 10:08 UTC by Andrea Iacovitti
Modified: 2011-09-17 16:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.7.2


Attachments
testcase (138 bytes, text/html)
2011-09-16 10:08 UTC, Andrea Iacovitti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Iacovitti 2011-09-16 10:08:00 UTC
Created attachment 63691 [details]
testcase

Version:           Git
OS:                Linux

The lineedit clearButton doesn't work for input text that has "value" attribute specified, i.e. <input type="text" value="ABCD" />

Reproducible: Always

Steps to Reproduce:
Load the testcase, click on clearButton to clear lineedit's content, focus out the lineedit

Actual Results:  
After focus out lineedit's content is restored to what's specified by the "value" attribute

Expected Results:  
After focus out lineedit's content must be empty
Comment 1 Andrea Iacovitti 2011-09-16 21:09:04 UTC
Git commit 24d7e18682e25fc8657980ac5521d8dea23fd293 by Andrea Iacovitti.
Committed on 16/09/2011 at 22:51.
Pushed by aiacovitti into branch 'KDE/4.7'.

Initialize QString variable to empty string.
It helps clearButton to work properly in khtml's forms.
BUG: 282133

M  +5    -5    kdeui/widgets/klineedit.cpp

http://commits.kde.org/kdelibs/24d7e18682e25fc8657980ac5521d8dea23fd293
Comment 2 Andrea Iacovitti 2011-09-16 21:48:58 UTC
Git commit 85b1c3ce1cd7a73ce7f537432f81dde4cc106b39 by Andrea Iacovitti.
Committed on 16/09/2011 at 22:51.
Pushed by aiacovitti into branch 'frameworks'.

Initialize QString variable to empty string.
It helps clearButton to work properly in khtml's forms.
BUG: 282133
(cherry picked from commit 24d7e18682e25fc8657980ac5521d8dea23fd293)

M  +5    -5    kdeui/widgets/klineedit.cpp

http://commits.kde.org/kdelibs/85b1c3ce1cd7a73ce7f537432f81dde4cc106b39
Comment 3 Andrea Iacovitti 2011-09-17 16:10:57 UTC
Git commit 6828cc00a65f1a1034065c787781043ae16dede8 by Andrea Iacovitti.
Committed on 17/09/2011 at 17:57.
Pushed by aiacovitti into branch 'KDE/4.7'.

Revert my previous changes to klineedit code and attempt to fix the bug
khtml side as David suggested.

CCBUG: 282133
FIXED-IN: 4.7.2
CCMAIL: faure@kde.org

M  +1    -1    kdeui/widgets/klineedit.cpp
M  +1    -1    khtml/rendering/render_form.cpp

http://commits.kde.org/kdelibs/6828cc00a65f1a1034065c787781043ae16dede8