Bug 281240 - Remove non-working "Disable desktop effects" option in power profile
Summary: Remove non-working "Disable desktop effects" option in power profile
Alias: None
Product: solid
Classification: Frameworks and Libraries
Component: powermanagement-kcm (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Dario Freddi
Depends on:
Reported: 2011-09-03 00:51 UTC by Baconmon
Modified: 2011-09-30 10:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Baconmon 2011-09-03 00:51:28 UTC
Version:           unspecified (using KDE 4.6.5) 
OS:                Linux

In <a href="show_bug.cgi?id=274048">Bug 274048</a> Manuel López-Ibáñez explains that "disable desktop effects" option in the power profiles dialog does not take effect when kde starts (and maybe some other cases)..

However, Martin Gräßlin explains how this option should not ever be used any way, and instead of fixing the problem, he marks the bug as WONTFIX..

So I am making this bug report now, stating that the option to disable compositing effects should be completely removed and is a bug to let it stay there in the broken condition it is in..

In summary, one of these two things should happen:
> Keep it in KDE but fix it..
> Don't fix it and just remove it instead..

What should not happen:
> Stays in KDE in a broken state..

Reproducible: Always

Steps to Reproduce:
Use KDE and use broken disable effects option..

Actual Results:  
You can interact with some thing that doesn't work correctly..

Expected Results:  
You don't see any option to disable effects in power profile..
Comment 1 Dario Freddi 2011-09-30 10:22:35 UTC
Git commit a22b5ea79087a1b0286fe223492dbac4fe67ccec by Dario Freddi.
Committed on 30/09/2011 at 12:20.
Pushed by dafre into branch 'master'.

Removing Disable Desktop Effects in 4.8.

Besides the fact this feature has never worked correctly, Martin confirmed it is
no longer useful, but instead harmful, for how compositing is handled in 4.8+.

CCMAIL: mgraesslin@kde.org
BUG: 267924
BUG: 281240

M  +0    -1    powerdevil/daemon/CMakeLists.txt
M  +0    -1    powerdevil/daemon/actions/bundled/CMakeLists.txt
D  +0    -105  powerdevil/daemon/actions/bundled/disabledesktopeffects.cpp
D  +0    -55   powerdevil/daemon/actions/bundled/disabledesktopeffects.h
D  +0    -99   powerdevil/daemon/actions/bundled/disabledesktopeffectsconfig.cpp
D  +0    -55   powerdevil/daemon/actions/bundled/disabledesktopeffectsconfig.h
D  +0    -114  powerdevil/daemon/actions/bundled/powerdevildisabledesktopeffectsaction.desktop
M  +0    -3    powerdevil/daemon/powerdevilactionpool.cpp