Bug 279611 - KMix Dock Widget display wrong volume, because of mistake in Volume::getAvgVolume
Summary: KMix Dock Widget display wrong volume, because of mistake in Volume::getAvgVo...
Alias: None
Product: kmix
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Christian Esken
Depends on:
Reported: 2011-08-07 19:52 UTC by Alexandr Akulich
Modified: 2011-08-11 22:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Patch, that revert sumOfActiveVolumes changing. (469 bytes, patch)
2011-08-07 19:53 UTC, Alexandr Akulich

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandr Akulich 2011-08-07 19:52:09 UTC
Version:           unspecified (using Devel) 
OS:                Linux

Commit 1242590 change "sumOfActiveVolumes = 0" to "sumOfActiveVolumes = _volumesL.size()", that introduce mistake in average volume calculation.

Reproducible: Always

Steps to Reproduce:
Compile/run last version and maximize or minimize volume.

Actual Results:  
"Volume at 101%" or "Volume at 1%" on dock widget.

Expected Results:  
"Volume at 100%" or "Volume at 0%" on dock widget.
Comment 1 Alexandr Akulich 2011-08-07 19:53:04 UTC
Created attachment 62644 [details]
Patch, that revert sumOfActiveVolumes changing.
Comment 2 Christian Esken 2011-08-11 22:21:10 UTC
Thanks for the patch. I will apply it immediately.
Comment 3 Christian Esken 2011-08-11 22:22:07 UTC
SVN commit 1246527 by esken:

BUGS: 279611
Fix wrong volume in KMix Dock Widget

 M  +1 -1      volume.cpp  

WebSVN link: http://websvn.kde.org/?view=rev&revision=1246527