Version: unspecified (using KDE 4.6.2)
Compare the following two screenshots:
There is a visual glitch just below the separator between the menu and tab bars in the bad screenshot, causing a sharp-edged patch of a slightly lighter gradient.
This glitch was introduced by commit bcd081da2f7679c4199019f0ba0e0bcb5d1741fd "Apply inner shadow hack on GtkViewport", determined by git bisect.
Steps to Reproduce:
Open an affected application (BOINC Manager in my testing). Observe separator.
Narrow line of lighter gradient visible below separator
No gradient difference visible
oxygen-gtk from git on Kubuntu 11.04 beta, KDE 4.6.2
mmm. Cannot reproduce here. Ruslan ? Can you ?
I should add that 11.04 has GTK 2.24.4.
The glitch also doesn't appear to manifest if BOINC manager loads when the system starts (i.e., I left it open when shutting down the computer). Close and reopen it and it appears, and continues to do so reliably from that point on.
Can't reproduce this on GTK 2.24.3.
Does this gradient appear if you apply this patch (it will make oxygen-gtk not draw window background, but is needed to somewhat localize the problem):
diff --git a/src/oxygenstyle.cpp b/src/oxygenstyle.cpp
index dbdf92e..8e5d81c 100644
@@ -228,6 +228,7 @@ namespace Oxygen
GdkRectangle* clipRect, gint x, gint y, gint w, gint h,
const StyleOptions& options, TileSet::Tiles tiles )
// define colors
ColorUtils::Rgba base( color( Palette::Window, options ) );
? Possibly let me see the screenshot with this patch applied.
The glitch isn't visible with this patch applied. Here are screenshots with and without the patch:
OK. Could you test (on clean master) if the glitch appears with ENABLE_INNER_SHADOWS_HACK set to 0 in CMakeLists.txt?
If it doesn't, could you give output with this patch (having ENABLE_INNER_SHADOWS_HACK reverted to 1):
diff --git a/src/animations/oxygeninnershadowdata.cpp b/src/animations/oxygeninnershadowdata.cpp
index 6014657..8845051 100644
@@ -19,6 +19,8 @@
* MA 02110-1301, USA.
+#define OXYGEN_DEBUG 1
Glitch doesn't appear with INNER_SHADOWS_HACK disabled. Here's the output with the debug patch:
Git commit 9e29948a7e00c2bcc29d8e4f0d1066a18f2a55c6 by Ruslan Kabatsayev.
Committed on 10/06/2011 at 20:13.
Pushed by kabatsayev into branch 'master'.
Disable inner shadow hack for GtkPizza
M +8 -4 src/animations/oxygeninnershadowdata.cpp
Please confirm that the above commit fixes this and close if yes.
Yup, that's fixed. Thanks!