Bug 262369 - kdesrc-build doesn't wait for source update for l10n modules before building
Summary: kdesrc-build doesn't wait for source update for l10n modules before building
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: Git
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-07 04:28 UTC by Michael Pyne
Modified: 2011-01-15 05:11 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pyne 2011-01-07 04:28:16 UTC
kdesrc-build doesn't wait for the source update for an l10n module to be completed before actually running the build phase, like it normally does for other modules.

Reproduce by removing the kde4-l10n source dir and build dir and trying to build just the l10n module (obviously with a few languages selected using kde-languages).

A workaround is (probably) to use the --no-async option when running kdesrc-build to update language modules for now, or to make sure you're building other modules in front of the l10n module so that the race condition is not noticeable.
Comment 1 Michael Pyne 2011-01-15 05:11:24 UTC
SVN commit 1214522 by mpyne:

Wait for l10n modules to update before building them.

kdesrc-build implements the kde-languages option by mapping the 'l10n-kde4'
module into l10n-kde4/{$kde-languages} (e.g. if you asked for de and fr, the
mapping would be l10n-kde4 -> (l10n-kde4/de, l10n-kde4/fr).

This had an issue which I didn't note before with updating the source and
performing builds in parallel: kdesrc-build uses module names to ensure the
source has updated before attempting the build, but the module names were
different when updating the source (plain l10n-kde4) and when performing the
build (the mapped module names)

I solved the issue by not mapping the module names until after the IPC update
was received for l10n-kde4. This fixes bug 262369.

BUG:262369


 M  +19 -3     kdesrc-build  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1214522