Bug 253641 - kde 4.5.2 - oxygen-settings -> disable 'Draw focus indicator' fails to disable edit-widget focus highlight
Summary: kde 4.5.2 - oxygen-settings -> disable 'Draw focus indicator' fails to disabl...
Status: RESOLVED INTENTIONAL
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-09 04:37 UTC by David Rankin
Modified: 2010-10-11 02:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot showing edit-widget highlight (84.01 KB, image/jpeg)
2010-10-09 04:37 UTC, David Rankin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Rankin 2010-10-09 04:37:14 UTC
Created attachment 52363 [details]
screenshot showing edit-widget highlight

Version:           unspecified (using Devel) 
OS:                Linux

In kde 4.5.2, when kate has focus, there is a bright colored rectangle (edit widget focus highlight) that draws itself around the editing window in kate/kwrite. (I use focus follows mouse)

Using oxygen-settings ->  Widget Style, -> Views, -> uncheck 'Draw focus indicator' 

AND restarting kate fails to disable to highlight around the edit-widget and it is quite annoying.

In the attached screenshot the unwanted highlight is the blue line around the edit widget.



Reproducible: Didn't try

Steps to Reproduce:
Use the oxygen theme, open kate, give the window focus and there is a bright highlight rectangle drawn around the edit widget.

Actual Results:  
disable 'Draw focus indicator' and restarting kate does NOT disable the edit-widget highlight

Expected Results:  
disable 'Draw focus indicator' and restarting kate should disable the edit-widget highlight
Comment 1 Hugo Pereira Da Costa 2010-10-09 17:11:17 UTC
yeah I guess its a naming ambiguity.
The "view" refered to in the config tab name is for tree views.
What the option disable is an horizontal like below focused item in trees. 
Doesn't affect glow in frames.

Now, concerning the glow in kate. It is the same glow as in many other frames 
(single line editors, tree-view frames, etc).
The problem with kate is that their editor is actually not a QTextEdit and a completely custom made widget that mimic an editor. But ... It does not respect the inner margins of a normal text editor, (see, e.g. the first page of 'oxygen-demo' (you can type it in konsole or krunner), for which I believe the inner glow you mention is not an issue (feel free to provide your opinion on the matter).

This (not respecting the margins), is a kate bug. (and I have plan to try address it. Btw it affects bespin, and skulpture in a similar manner, even without the glow). 

Are you ok if we
- rename the option tab (for kde4.6) from "views" to "list views" (or lists)
- don't do anything in oxygen
- file a bug report to Kate, on the margin issue, and try fix it.

?
Comment 2 Hugo Pereira Da Costa 2010-10-09 17:12:50 UTC
PS: on your screenshot, the same glow is seen in your oxygen-settings window, on the left side list. I do believe that it looks quite nice there, which is what I'm quite not in favor of adding an option for disabling it. You agree ?
Comment 3 David Rankin 2010-10-10 23:18:52 UTC
An option you cannot disable is a BUG...

The problem is that system-settings -> common appearance -> app appearance -> colors -> hover decoration should NOT be enabled continually around the edit widget. 

Further, I don't agree that it looks good. To me it looks horrible to have a nice dark theme setup only to some damn bright hover decoration highlight splashed around your edit window in kate.

Second with the oxygen-settings ->  Widget Style, -> Views, -> uncheck 'Draw focus indicator'

... when that is unchecked, the focus indications, including hover decoration should be - OFF.

Focus on the problem -- don't tell me the problem looks good...
Comment 4 Hugo Pereira Da Costa 2010-10-11 02:49:06 UTC
> --- Comment #3 from David Rankin <drankinatty suddenlinkmail com> 
> 2010-10-10 23:18:52 --- An option you cannot disable is a BUG...

First of all, please watch your tone.

Then to answer your comments

1/ this is not an option, its a design choice, so that no we don't have to provide an option for disabling it and no that does not make it a bug. This hover effect was in oxygen from day 1, never was to be disabled. 

2/ if you don't like the color used for hover in your dark color scheme, you 
can always change it to have something less bright. 

> The problem is that system-settings -> common appearance -> app appearance
> -> colors -> hover decoration should NOT be enabled continually around the
> edit widget.

This is again, a design choice, not a configurable design. So your *should not* is incorrect. From the Oxygen's designer's point of view, it *should*, on hover. 
 
> Further, I don't agree that it looks good. To me it looks horrible

Point taken. 
'Horible' and 'good' are subjective concepts anyway. It does look good, however, to the people who designed this theme, and to the people who coded it.

> to have
> a nice dark theme setup only to some damn bright hover decoration
> highlight splashed around your edit window in kate.

Cursing is useless and non constructive.

> 
> Second with the oxygen-settings ->  Widget Style, -> Views, -> uncheck
> 'Draw focus indicator'
> 
> ... when that is unchecked, the focus indications, including hover
> decoration should be - OFF.

I tried to explain this point in the previous comment.

> 
> Focus on the problem -- don't tell me the problem looks good...
My point, is that there is no problem here in oxygen, the problem is in kate, 
and I said I will focus on it. Besides, who are you to tell me what to do, what should be, and what should not. 

Closing this bug, as wont fix, cause it wont.
The corresponding kate bug might get fixed though.