I'm trying to port this to trunk now.

Created attachment 51875 [details]
patch against trunk

The patch against trunk doesn't cause regressions.

Thanks a lot for porting my patch to trunk faster than I could!  I've looked at the patch, and I believe it to be complete.  My only concern is that some of the literals in the qBound calls in trunk have been converted as "qreal(0.0)" rather than "(qreal) 0.0", whereas they were left with my "(qreal) 0.0" in the ported patch.  I believe "qreal(0.0)" is better for performance, improves readability, and is probably how the new literal changes should also be made, if for no other reason than preservation of style within the krita codebase.  If someone else isn't faster, I'll adjust the patch against trunk in about 24 hours, but if someone else is faster, that's great too :)

I think that's because someone else already had changed those qreal lines in between 2.2 and trunk :-). I seem to remember some commits about that. I'm fine with you committing; thanks for the effort!

Created attachment 51895 [details]
Renewed patch against current trunk

Mostly the same as the previous.  Some casts converted to qreal() rather than (qreal).  qBound() switched to qBound<qreal>() to match prior changes in the source (and not need explicit casts for each argument).

SVN commit 1178606 by jriddell:

Replace use of double with qreal, fixes
Bug 251866 - KOffice does not compile on ARM
patch by Emmet Hikory <persia@canonical.com>
BUG:251866


 M  +32 -32    image/brushengine/kis_paint_information.cc  
 M  +13 -13    image/brushengine/kis_paint_information.h  
 M  +7 -7      image/brushengine/kis_paintop.cc  
 M  +1 -1      image/brushengine/kis_paintop.h  
 M  +9 -9      image/kis_convolution_kernel.cc  
 M  +1 -1      image/kis_convolution_kernel.h  
 M  +13 -13    image/kis_filter_strategy.cc  
 M  +11 -11    image/kis_filter_strategy.h  
 M  +12 -12    image/kis_painter.cc  
 M  +9 -9      image/kis_painter.h  
 M  +12 -12    image/kis_shear_visitor.cpp  
 M  +5 -5      image/kis_shear_visitor.h  
 M  +4 -4      image/kis_transform_visitor.h  
 M  +2 -2      image/tests/kis_paintop_test.cpp  
 M  +1 -1      plugins/colorspaces/ctlcs/KoCtlMixColorsOp.cpp  
 M  +1 -1      plugins/paintops/chalk/kis_chalk_paintop.cpp  
 M  +1 -1      plugins/paintops/chalk/kis_chalk_paintop.h  
 M  +4 -4      plugins/paintops/complexop/kis_complexop.cpp  
 M  +1 -1      plugins/paintops/complexop/kis_complexop.h  
 M  +1 -1      plugins/paintops/curvebrush/kis_curve_paintop.cpp  
 M  +1 -1      plugins/paintops/curvebrush/kis_curve_paintop.h  
 M  +5 -5      plugins/paintops/defaultpaintops/brush/kis_brushop.cpp  
 M  +18 -18    plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.cpp  
 M  +2 -2      plugins/paintops/defaultpaintops/duplicate/kis_duplicateop.h  
 M  +1 -1      plugins/paintops/defaultpaintops/smudge/kis_smudgeop.h  
 M  +1 -1      plugins/paintops/deform/kis_deform_paintop.cpp  
 M  +2 -2      plugins/paintops/deform/kis_deform_paintop.h  
 M  +1 -1      plugins/paintops/dynadraw/kis_dyna_paintop.cpp  
 M  +1 -1      plugins/paintops/dynadraw/kis_dyna_paintop.h  
 M  +1 -1      plugins/paintops/experiment/kis_experiment_paintop.cpp  
 M  +3 -3      plugins/paintops/experiment/kis_experiment_paintop.h  
 M  +4 -4      plugins/paintops/filterop/kis_filterop.cpp  
 M  +1 -1      plugins/paintops/filterop/kis_filterop.h  
 M  +1 -1      plugins/paintops/gridbrush/kis_grid_paintop.cpp  
 M  +4 -4      plugins/paintops/gridbrush/kis_grid_paintop.h  
 M  +1 -1      plugins/paintops/hairy/kis_hairy_paintop.cpp  
 M  +1 -1      plugins/paintops/hairy/kis_hairy_paintop.h  
 M  +4 -4      plugins/paintops/mypaint/mypaint_paintop.cpp  
 M  +2 -2      plugins/paintops/mypaint/mypaint_paintop.h  
 M  +1 -1      plugins/paintops/particle/kis_particle_paintop.cpp  
 M  +1 -1      plugins/paintops/particle/kis_particle_paintop.h  
 M  +3 -3      plugins/paintops/spray/kis_spray_paintop.cpp  
 M  +2 -2      plugins/paintops/spray/kis_spray_paintop.h  
 M  +3 -3      plugins/paintops/spray/random_gauss.cpp  
 M  +3 -2      plugins/paintops/spray/random_gauss.h  
 M  +1 -1      plugins/paintops/spray/spray_brush.cpp  
 M  +1 -1      ui/recorder/kis_recorded_paint_action_editor.cc  
 M  +1 -1      ui/tool/kis_tool_paint.cc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1178606

Correcting e-mail address from the commit:
patch by Emmet Hikory <persia@ubuntu.com>

Thanks.  Honored to be considered Canonical for a few minutes, but better not to claim something I can't.