Bug 248648 - k3b ignores and/or resets settings' program search path
Summary: k3b ignores and/or resets settings' program search path
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: 2.0.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Michał Małek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-22 02:16 UTC by J. Randall Owens
Modified: 2010-09-04 09:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.0.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description J. Randall Owens 2010-08-22 02:16:00 UTC
Version:           2.0.0 (using KDE 4.4.5) 
OS:                Linux

While going through the k3b settings, I noticed an "/opt/schily/bin/" entry in the Search Path tab of the Programs subdialog (or whatever you call that level of the tree), and figured I'd get rid of it since I have no "/opt/schily" at all, and while I was at it put the "/usr/local/*bin" entries before the "/usr/*bin", where they belong.  So I clicked the schily entry, and the remove button, and it was gone.

But after I'd restarted k3b, looking through my settings, I noticed that it was back, and the local paths were back where they had started.  I shut down k3b, poked around in ~/.kde/share/config/k3brc, and saw that it did have a line:

search path[$e]=/usr/bin/,/usr/local/bin/,/usr/sbin/,/usr/local/sbin/,/opt/schily/bin/,/sbin

Figured I'd go in and hand-edit it with emacs, and get rid of the schily part at least, and if that took I'd go back and try changing the order.  Start it back up, look in the settings, and it's back.  Grep the k3brc, and it's still as I left it, but it's reset to include the schily path as soon as I exit k3b.


Reproducible: Always

Steps to Reproduce:
1. Start up k3b.
2. In Settings -> Programs -> Search Path, change the list of directories, e.g. by removing /opt/schily/bin
3. Quit and restart
4. Look in Search Path again

Actual Results:  
path was reset to what it originally was

Expected Results:  
path is retained as I'd set it

My c++-fu is terribly weak, so I'm not sure what's going on, but it looks like maybe grp.writePathEntry is saving m_searchPath, which is being set by loadDefaultSearchPath when it shouldn't be.  Maybe when loadDefaultSearchPath is called from setSearchPath?

I don't think it's related, but a shared root cause is possible, the original reason I was poking around in settings is that k3b doesn't seem to be respecting my choices of quality in the lame plugin settings.  But that doesn't seem to be resetting configuration options in k3brc, just ignoring them, as I'm always getting (according to `file` output) 128 kbps JntStereo MP3s, whatever the settings I've chosen from the plugin.  But there, the settings are staying as I want them in k3brc, e.g. "Mode=stereo", "Quality Level=8", they're just being ignored (or else file is wrong, but the filesizes seem right for 128kbps).  So it's probably unrelated, but has similar effect.
Comment 1 Michał Małek 2010-09-04 09:23:10 UTC
SVN commit 1171163 by mmalek:

Fixed saving program options' search paths. Don't call loadDefaultSearchPath() when setting new search path list.
BUG: 248648


 M  +1 -0      ChangeLog  
 M  +3 -6      libk3b/core/k3bexternalbinmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1171163
Comment 2 Michał Małek 2010-09-04 09:24:11 UTC
SVN commit 1171164 by mmalek:

Fixed saving program options' search paths. Don't call loadDefaultSearchPath() when setting new search path list.
BUG: 248648

 M  +1 -0      ChangeLog  
 M  +2 -5      libk3b/core/k3bexternalbinmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1171164