Bug 247386 - make perf does not run all performance tests, perl perf/vg_perf does not work for these
Summary: make perf does not run all performance tests, perl perf/vg_perf does not work...
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.6 SVN
Platform: Unlisted Binaries Linux
: NOR minor
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-11 16:21 UTC by Philippe Waroquiers
Modified: 2011-12-23 11:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
move 2 perf tests to perf directory+ensure make perf works with these (10.76 KB, text/plain)
2011-12-20 11:18 UTC, Philippe Waroquiers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Waroquiers 2010-08-11 16:21:53 UTC
make perf only runs the tests in valgrind/perf directory.
There are other performance tests in memcheck/perf and massif/perf which
are not being run.
Trying to run them manually gives a problem, e.g. 

  perl perf/vg_perf massif/perf/many-xpts
  many-xpts valgrind  :0.05s  no:
  *** Command returned non-zero (256)
  *** See perf.{cmd,stdout,stderr} to determine what went wrong.

The problem is due to the vgopts which do not specify the tool for the option.
e.g. memcheck/perf/many-loss-records fails with none tool launched
by vg_perf because it contains:
    vgopts: --leak-check=yes --leak-resolution=high
Comment 1 Philippe Waroquiers 2011-12-20 11:18:39 UTC
Created attachment 66931 [details]
move 2 perf tests to perf directory+ensure make perf works with these
Comment 2 Florian Krohm 2011-12-20 20:14:29 UTC
Consolidating the performance related testcases in a single directory is a good thing. We only have a few such testcases anyhow, so distributing them is not necessary. I completely missed those two testcases when I was doing some performance measurements a few months ago....
Comment 3 Philippe Waroquiers 2011-12-23 11:48:37 UTC
fixed in revision 12315