Bug 246888 - Improve Makefile.vex.am
Summary: Improve Makefile.vex.am
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 11:37 UTC by Florian Krohm
Modified: 2010-09-28 17:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for Makefile.vex.am (777 bytes, patch)
2010-08-06 11:37 UTC, Florian Krohm
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Krohm 2010-08-06 11:37:44 UTC
Created attachment 49867 [details]
Patch for Makefile.vex.am

Version:           unspecified
OS:                Linux

The file pub/libvex_guest_offsets.h does not get regenerated if 
auxprogs/genoffset.c  or any of the guest header files changes.
The attached patch fixes this. The patch is against r11250


Reproducible: Always
Comment 1 Christian Borntraeger 2010-09-24 13:16:07 UTC
Any chance to apply that?

This patch seems trivial and makes porting new architectures less error prone, since you do not need to run make clean after editing the vex guest state.
Comment 2 Julian Seward 2010-09-28 17:10:11 UTC
Committed, r11387.  Thanks for the patch.