Bug 211853 - rethink puzzle table zooming
Summary: rethink puzzle table zooming
Status: RESOLVED FIXED
Alias: None
Product: palapeli
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: VHI normal
Target Milestone: 1.0
Assignee: Stefan Majewsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-25 23:58 UTC by Stefan Majewsky
Modified: 2009-10-26 16:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Majewsky 2009-10-25 23:58:12 UTC
Version:            (using KDE 4.3.2)
Installed from:    openSUSE RPMs

[This feature request has been imported manually from a todolist in SVN.]

Problems with the current implementation:
1. While most zoom widgets have 100% in the middle of the zoom slider, in Palapeli, 100% means seeing the whole puzzle table, and this is the smallest possible zoom level.
2. There is an artificial border around the puzzle table. It would be much better if it expanded automagically when puzzle pieces are moved to the sides.
Comment 1 Stefan Majewsky 2009-10-26 15:33:14 UTC
SVN commit 1040612 by majewsky:

Work towards a more liberal viewport movement and zooming strategy:
* Remove the scene size factor from the UI (it's now hardcoded to 2.5, and will be completely removed later).
* Allow to deactivate the scene size constraint which is represented by the greyed-out areas. In fact, it's off by default.
* The zoom widget has a new toolbutton for enabling and disabling the scene size constraint.

CCBUG: 211853


 M  +1 -0      engine/inaccessibleareashelper.cpp  
 M  +1 -1      engine/inaccessibleareashelper.h  
 M  +24 -15    engine/part.cpp  
 M  +3 -3      engine/part.h  
 M  +36 -3     engine/scene.cpp  
 M  +8 -1      engine/scene.h  
 M  +1 -9      engine/view.cpp  
 M  +0 -1      engine/view.h  
 M  +16 -0     engine/zoomwidget.cpp  
 M  +3 -0      engine/zoomwidget.h  
 M  +0 -4      palapeli.kcfg  
 M  +22 -76    settings.ui  
 M  +2 -0      window/puzzletablewidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1040612
Comment 2 Stefan Majewsky 2009-10-26 16:30:30 UTC
SVN commit 1040632 by majewsky:

More zooming improvements:
* InaccessibleAreasHelper does not completely vanish when it's disabled.
* Scene rect is also automatically adjusted when pieces are only moving.
* Zooming feels more natural. New base point is 100%, i.e. original size of pieces.
BUG: 211853


 M  +8 -4      engine/inaccessibleareashelper.cpp  
 M  +3 -0      engine/part.cpp  
 M  +1 -0      engine/part.h  
 M  +16 -10    engine/scene.cpp  
 M  +2 -0      engine/scene.h  
 M  +30 -52    engine/view.cpp  
 M  +8 -6      engine/view.h  
 M  +7 -11     engine/zoomwidget.cpp  
 M  +2 -4      engine/zoomwidget.h  
 M  +2 -2      window/puzzletablewidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1040632