Bug 200890 - Allow user to drag or move tabs
Summary: Allow user to drag or move tabs
Status: RESOLVED FIXED
Alias: None
Product: kile
Classification: Applications
Component: general (show other bugs)
Version: 2.0.3
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Michel Ludwig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 16:57 UTC by Claus Appel
Modified: 2010-08-21 18:41 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch for movable tabs in Kile 2.1 beta 4 (534 bytes, patch)
2010-08-05 22:19 UTC, Nicolas Pavillon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Claus Appel 2009-07-20 16:57:25 UTC
Version:           2.0.3 (using 3.5.10-11.fc11 Fedora, Fedora release 10.92 (Rawhide))
Compiler:          Target: i586-redhat-linux
OS:                Linux (i686) release 2.6.29.5-191.fc11.i586

Kile allows the user to have multiple documents open as tabs. But the order of the tabs in the tab bar is fixed. If I want to re-arrange the tabs, I have to close and re-open them. I request: 

1. Allow the user to right-click the tab's name (in the tab bar) and get a drop-down menu with a "move tab left" and "move tab right" option. 
2. Allow the user to click and drag tabs with the mouse.
3. Allow keyboard shortcuts for "move tab left" and "move tab right".
Comment 1 Nicolas Bigaouette 2010-05-07 16:32:40 UTC
Would like the same thing. Using KDE 4.4.3
Comment 2 Jonathan Kolberg 2010-06-07 22:36:01 UTC
*** This bug has been confirmed by popular vote. ***
Comment 3 Nicolas Pavillon 2010-08-05 22:19:23 UTC
Created attachment 49848 [details]
Patch for movable tabs in Kile 2.1 beta 4
Comment 4 Nicolas Pavillon 2010-08-05 22:19:39 UTC
I noticed that having movable tabs could be easily done by setting the Movable property to true. Furthermore, Kile seems to behave badly when a lot of documents are open (more than 10, typically). For this reason, I also suggest the activation of the UsesScrollButton property.
Please see the attached diff file, made from Kile 2.1 beta 4, rev 1159306. 

The changes were tested on Unix (Kubuntu 10.04.1) and Mac OSX (10.6.4).
Comment 5 Michel Ludwig 2010-08-06 11:03:55 UTC
(In reply to comment #4)
> I noticed that having movable tabs could be easily done by setting the Movable
> property to true. Furthermore, Kile seems to behave badly when a lot of
> documents are open (more than 10, typically). For this reason, I also suggest
> the activation of the UsesScrollButton property.
> Please see the attached diff file, made from Kile 2.1 beta 4, rev 1159306. 
> 
> The changes were tested on Unix (Kubuntu 10.04.1) and Mac OSX (10.6.4).

Thanks for patch, but it's not as easy as it seems to implement this feature. :-)

However, I'll see what I can do...
Comment 6 Michel Ludwig 2010-08-06 14:12:42 UTC
SVN commit 1159863 by mludwig:

- Make the view tabs movable (initial patch by Nicolas Pavillon)
- Add actions to move the view tabs left or right
- Fix a bug in the 'fileCloseAllOthers' method of the doc manager

BUG: 200890

 M  +6 -3      kile.cpp  
 M  +48 -9     kiledocmanager.cpp  
 M  +4 -3      kiledocmanager.h  
 M  +4 -5      kileinfo.cpp  
 M  +113 -14   kileviewmanager.cpp  
 M  +12 -5     kileviewmanager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1159863
Comment 7 Michel Ludwig 2010-08-06 14:14:42 UTC
(In reply to comment #6)
> SVN commit 1159863 by mludwig:
> 
> - Make the view tabs movable (initial patch by Nicolas Pavillon)
> - Add actions to move the view tabs left or right
> - Fix a bug in the 'fileCloseAllOthers' method of the doc manager

This should do the trick. Can you please test it carefully? Thanks.
Comment 8 Nicolas Pavillon 2010-08-21 17:16:43 UTC
Sorry, my tiny patch indeed overlooked quite some elements.
I tried the movable tabs in various methods, and could not find bugs at this point.
Comment 9 Michel Ludwig 2010-08-21 18:41:57 UTC
(In reply to comment #8)
> Sorry, my tiny patch indeed overlooked quite some elements.
> I tried the movable tabs in various methods, and could not find bugs at this
> point.

That's good to hear. Many thanks for the testing.