Bug 196178 - zoom in/out: provide two new modes (zoom here + zoom focus)
Summary: zoom in/out: provide two new modes (zoom here + zoom focus)
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 322834 355724 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-12 14:20 UTC by Maciej Pilichowski
Modified: 2017-04-19 08:48 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2009-06-12 14:20:46 UTC
Version:            (using KDE 4.2.90)

Both modes make sense only in relation to mouse cursor, however in case of no mouse cursor over the image, there could be used some default location.

Zoom here: zoom in/out in such way, that pixel under the mouse cursor is exactly the same (in sense of coordinates).

Zoom focus: zoom in/out in such way, that pixel under mouse cursor is more centered with each zoom (IOW scroll while zooming). 

Both modes need this report to implemented:
https://bugs.kde.org/show_bug.cgi?id=196176

I think the current zoom could be dropped in favor of "zoom here" which would make transition from Gimp easier for users. One advantage (as writing this report), Gimp zoom here is buggy (it does not zoom correctly when entire image fits on the screen).
Comment 1 Halla Rempt 2011-05-26 21:59:58 UTC
Ack, our zoom handling needs fixing. Not sure whether it's going to happen the way you describe, but Dmitry is working on it.
Comment 2 Dmitry Kazakov 2013-01-23 09:57:02 UTC
I guess until recently we had the Zoom Tool which was supposed to do exactly what is explained here ("Zoom Focum"). Probably, we should revert it back...
Comment 3 David REVOY 2014-06-26 15:25:22 UTC
I add this note on this old thread to add a +1 bump to **Zoom to cursor position**  ( aka Zoom Focus here ) as default zoom behavior for the Continuous Zoom toggle mode ( even if I contributed in the past to choose a centered Zoom Tool during the navigation/pan/zooming refactor, and reject a first "Zoom to cursor". Mea culpa ). 

Reasons :
========
- This Twitter discution :  https://twitter.com/manujarvinen/status/481877254252011520
- Consistency : within Krita "Mousewheel zoom in/out" because it works already centered to cursor. 

Affected current shortcuts : 
========================
- Ctrl+MiddleMouseButton+LeftClick  (Toggle Zoom Mode)
- Ctrl+Space+Leftclick  (Toggle Zoom Mode)

Test :
====
Mypaint Ctrl+Mousewheel ,and Ctrl+Space works already centered to cursor position, and I could test that as a proof of concept; it works and it ease the navigation. ( no need to perform Zoom Ctrl+Space , then Space alone to pan ;  "Zooming to cursor" frames the expected part of the artwork ).
Comment 4 Halla Rempt 2015-06-23 07:58:40 UTC
Deevad,

Can you test the patch in https://phabricator.kde.org/T427 ?
Comment 5 Halla Rempt 2015-12-10 08:13:38 UTC
*** Bug 322834 has been marked as a duplicate of this bug. ***
Comment 6 Halla Rempt 2015-12-10 08:13:48 UTC
*** Bug 355724 has been marked as a duplicate of this bug. ***
Comment 7 Halla Rempt 2016-01-24 15:21:49 UTC
Okay, we had a patch on phab for this. The interaction design didn't work out, so that needs more work. Scott, Deevad, Wolthera and Animtim need to take the lead here.

WISHGROUP: Larger Usability Fixes
Comment 8 David REVOY 2016-02-04 11:33:34 UTC
>> Okay, we had a patch on phab for this. The interaction design didn't work out, so that needs more work. Scott, Deevad, Wolthera and Animtim need to take the lead here.
Ok, I can (re)test it. I remember I tested something in the past that wasn't working and I probably gave feedback on IRC because their is no history on this bug-report or on Phabricator about it. Sorry about this, and for my slow answer on this topic. I lost it somehow.

>> Can you test the patch in https://phabricator.kde.org/T427 ?
Hard for me to test it now because I can't find the patch on the Phabricator UI.
Comment 9 David REVOY 2016-02-11 20:46:27 UTC
>> Hard for me to test it now because I can't find the patch on the Phabricator UI.
I found the patch today on Phabricator, and I also found I already commented/tested about it :)
It's here: https://phabricator.kde.org/D125#2255
Comment 10 Scott Petrovic 2016-07-17 18:00:05 UTC
Can we close this ticket? Does the zoom tool that was added to the toolbox do everything that was needed?
Comment 11 David REVOY 2016-07-17 18:05:42 UTC
@Scott:  Let's keep this ticket open:
- Ctrl+MiddleMouseButton+LeftClick
- Ctrl+Space+Leftclick
still zoom in the center of the canvas and not at the cursor position.
Comment 12 yustas 2016-07-19 05:46:59 UTC
The zoom tool is the very important one. It is my second frequently used tool after the brush. But this tool does not work well unfortunately.
Comment 13 Raghavendra kamath 2017-04-18 13:59:47 UTC
The patch mentioned in the phab page https://phabricator.kde.org/D125#2255 has been pushed by dmitry. And I see we have an option for relative zoom mode option in the canvas input settings. Is this bug still open or is there any thing else required in the zoom tool?
Comment 14 Halla Rempt 2017-04-19 08:48:17 UTC
I think we can close it.