Bug 194066 - amarok stops playing if random albums is selected and only one album in playlist
Summary: amarok stops playing if random albums is selected and only one album in playlist
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.1-SVN
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-25 19:34 UTC by Marius Orcsik
Modified: 2009-08-18 16:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Orcsik 2009-05-25 19:34:40 UTC
Version:           2.1-SVN (972775) (using KDE 4.2.3)
Compiler:          gcc (GCC) 4.4.0 20090505 (prerelease) 
OS:                Linux
Installed from:    Unlisted Binary Package

How to reproduce:
When selecting the Random Albums mode and the playlist contains only one album, Amarok stops playing after the first song. No modifications have been made to the playlist. (I'm using the svn version 972775 on Arch linux with KDE 4.2.3)

Expected behaviour:
Amarok should be playing the whole album - in the track order presumably.
Comment 1 Alexey Shildyakov 2009-06-25 14:26:57 UTC
Confirm on 2.2-SVN
Comment 2 Myriam Schweingruber 2009-06-25 16:40:45 UTC
You do not seriously expect it to play in the track order when Random mode is activated, don't you? This would not be random at all...

*** This bug has been marked as a duplicate of bug 182522 ***
Comment 3 Marius Orcsik 2009-06-25 16:53:13 UTC
I beg to differ about Myriam's decision. 

This is not a duplicate of bug 182522: 
182522 is treating random _tracks_ with repeat enabled/disabled.
194066 is treating random _albums_ with only one album in the playlist.

It might be the case of being the same reason behind, but this bug clearly shows broken behaviour.

To answer the pointless question: 
Expected behaviour is that Amarok should play the whole album in the same order as if there would be more than one in the playlist: in the track order.
Comment 4 Marius Orcsik 2009-06-25 16:57:44 UTC
Also, I have tested with all three Repeat options:
The bahaviour is exactly the same.

This has been done on version 2.2-SVN (R983911).
Comment 5 Edward Hades 2009-08-18 16:22:28 UTC
Fixed by commit 1183a6dd7f2efc849b8017a5a1c0fd95937f0dba
Author: Edward Hades <edward.hades@gmail.com>
Date:   Tue Aug 18 17:15:35 2009 +0400

    Fixed RandomAlbumNavigator glitches.

    The old behavior was to stop, when there are no upcoming albums, and no
    played albums. But that doesn't mean the playlist is empty, since it
    could contain single current album.

    Also navigator loved to skip one track, that was fixed too.

    BUG: 194066

 ChangeLog                                        |    2 ++
 src/playlist/navigators/RandomAlbumNavigator.cpp |    8 ++++----
 2 files changed, 6 insertions(+), 4 deletions(-)