Bug 188896 - moving feeds in feed-list between two feeds inserts at wrong position
Summary: moving feeds in feed-list between two feeds inserts at wrong position
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.4.1
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-05 17:46 UTC by M G Berberich
Modified: 2009-04-09 12:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Fix off-by-one (339 bytes, patch)
2009-04-05 21:19 UTC, Haakon Nilsen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description M G Berberich 2009-04-05 17:46:54 UTC
Version:           1.4.1 (using 4.2.1 (KDE 4.2.1), Debian packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.26-1-686

trying to reorder feeds in the feed-list, one can drag-n-drop a feed to another position. If a dragged feed is positioned exactly between two feeds a faint horizontal line appears, indicating that one can drop the feed here. If one does drop the feed it gets not inserted at the place of the faint line but one row below.

BTW: The indicator was much better in KDE3-akregtor, where it was not a faint line but a small gray area.
Comment 1 Haakon Nilsen 2009-04-05 21:19:04 UTC
Created attachment 32638 [details]
Fix off-by-one

Confirmed. This seems to be an off-by-one error fixed by the attached patch.

As an aside, I think the dragged item should retain selected status after the move, which it does not currently.
Comment 2 Frank Osterfeld 2009-04-07 11:40:07 UTC
SVN commit 950473 by osterfeld:

insert dropped items at correct position
Patch by Haakon Nilsen
BUG:188896


 M  +1 -1      folder.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=950473
Comment 3 fubanatorio 2009-04-09 03:11:09 UTC
i have the exact same problem with the Feed-Folders. I use 1.4.2 with Kontact.

So this is not fully Fixed! And its a mess to see this little tiny line-indicator, make it bigger or something, please!!
Comment 4 Haakon Nilsen 2009-04-09 12:20:08 UTC
Do you mean you still have the problem after applying the patch? Can you describe how to reproduce, please?

The line rendering is provided by Qt and not by Akregator directly. So it's probably a style thing. I think it looks fine as it is, but that's my opinion.