Bug 183022 - 'copy link location' does not copy into primary buffer
Summary: 'copy link location' does not copy into primary buffer
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: internal browser (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-03 17:28 UTC by Florian Loitsch
Modified: 2009-05-21 19:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
A Patch to correct the bug (against latest trunk) (798 bytes, patch)
2009-05-14 18:56 UTC, Shlomi Fish
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Loitsch 2009-02-03 17:28:04 UTC
Version:            (using KDE 4.2.0)
OS:                Linux
Installed from:    Unlisted Binary Package

'copy link location' does not copy into primary buffer

until kde 4.2 'copy link location' copied the link address into the primary X buffer (maybe into the clipboard too).
Since kde 4.2 it is only in the clipboard.

Reproduce: 'copy link location' (of any address). Paste the primary buffer (usually middle click) somewhere.

This bug resembles bug 102956.
Comment 1 Shlomi Fish 2009-02-05 21:16:15 UTC
Can confirm here. KDE-4.2.0's akregator on Mandriva Cooker, installed from Mandriva's RPMs. It's very annoying. Please fix it.
Comment 2 Shlomi Fish 2009-05-14 18:56:44 UTC
Created attachment 33667 [details]
A Patch to correct the bug (against latest trunk)

This patch corrects this bug. It was a simple matter of uncommenting a commented-out line. The comment about the commented out line read:

{{{{{{{
// don't set url to selection as it's a no-no according to a fd.o spec
}}}}}}}

And I've changed it to:

{{{{
// Setting the selection to the URL is apparantly a no-no according to a
// freedesktop.org spec (which ?), but users have complained and so we
// restore it.
}}}}

I will now punish all the ivory-tower freedesktop.org spec-writers by having them spend a year reading RSS using akregator, without this patch so they'll understand how inane their recommendations are.

Regards,

-- Shlomi Fish
Comment 3 Frank Osterfeld 2009-05-14 19:33:22 UTC
SVN commit 967999 by osterfeld:

Make "copy link location" copy the URL to the primary selection buffer (what gets pasted on middle-click) again.
Some unspecified spec allegedly says it's wrong, but nobody seems to care, so reenable it for consistency's sake
.
Following a patch by Shlomi Fish

BUG:183022


 M  +3 -1      articleviewer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=967999
Comment 4 Shlomi Fish 2009-05-19 13:04:36 UTC
The patch with the fix was not applied to the trunk yet. Why?

Regards,

-- Shlomi Fish
Comment 5 Frank Osterfeld 2009-05-21 19:14:51 UTC
SVN commit 971103 by osterfeld:

forwardport:

 Make "copy link location" copy the URL to the primary selection buffer (what gets pasted on middle-click) again.
 Some unspecified spec allegedly says it's wrong, but nobody seems to care, so reenable it for consistency's sake.

 Following a patch by Shlomi Fish

CCBUG:183022

 M  +3 -1      articleviewer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=971103