Bug 181130 - dbus is missing 3 handy calls which were existent in dcop
Summary: dbus is missing 3 handy calls which were existent in dcop
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Unclassified
Component: Tools/Script Manager (show other bugs)
Version: 2.0.1
Platform: unspecified Linux
: NOR wishlist (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-18 02:07 UTC by Martin Blumenstingl
Modified: 2009-12-09 11:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Blumenstingl 2009-01-18 02:07:50 UTC
Version:           2.0.1 (using KDE 4.1.3)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Unlisted Binary Package

evening

in Amarok 1.x there were three handy dcop calls:
void volumeDown() Decrease volume by a reasonable step.
void volumeUp()   Increase volume by a reasonable step. 
void mute() 	  Toggle mute. 

since Amarok switched from dcop to dbus with amarok 2.0 those calls do not exist anymore
also the MPRIS documentation does not mention any of them (which might be one of the reasons why those calls are not implemented [yet])

it would be really nice if someone could add some equivalent dbus calls for amarok 2

Thanks in advance + have a nice evening

Regards,
Martin
Comment 1 Seb Ruiz 2009-01-18 02:21:18 UTC
SVN commit 912684 by seb:

Added DBus methods: VolumeUp, VolumeDown, Mute. This is outside the
scope of mpris, but I rationalise that we need to provide script writers
with convenience functions.
BUG: 181130

 M  +1 -0      ChangeLog  
 M  +15 -0     src/dbus/PlayerDBusHandler.cpp  
 M  +19 -6     src/dbus/PlayerDBusHandler.h  
 M  +12 -0     src/dbus/org.freedesktop.MediaPlayer.player.xml  


WebSVN link: http://websvn.kde.org/?view=rev&revision=912684