Bug 173324 - DBus GetMetadata Query does not Return the Mandatory location field
Summary: DBus GetMetadata Query does not Return the Mandatory location field
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Mandriva RPMs Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 21:24 UTC by Shlomi Fish
Modified: 2008-10-23 10:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shlomi Fish 2008-10-22 21:24:11 UTC
Version:           amarok-1.90-0.872469.1mdv2009.1 (using KDE 4.1.2)
OS:                Linux
Installed from:    Mandriva RPMs

With Amarok 2 ( amarok-1.90-0.872469.1mdv2009.1 - installed from a hacker .src.rpm with the latest-as-of-then-svn-snapshto), running:

{{{{{{{{{{{{
shlomi:~/Docs/Notes/To_Do$ dbus-send --type=method_call --dest=org.kde.amarok /TrackList --print-reply=literal org.freedesktop.MediaPlayer.GetMetadata int32:0
   array [                                                                    
      dict entry(                                                             
         album         variant             Unknown      )                     
      dict entry(                                                             
         artist         variant             Unknown      )                    
      dict entry(                                                             
         audio-bitrate         variant             int32 0                    
      )                                                                       
      dict entry(                                                             
         audio-samplerate         variant             int32 0                 
      )
      dict entry(
         comment         variant                   )
      dict entry(
         genre         variant             Unknown      )
      dict entry(
         mtime         variant             int32 0
      )
      dict entry(
         rating         variant             int32 0
      )
      dict entry(
         time         variant             int32 0
      )
      dict entry(
         title         variant             Dolly Parton - Applejack-sPPUJFR620Y.avi      )
      dict entry(
         tracknumber         variant             int32 0
      )
      dict entry(
         year         variant             0      )
   ]
}}}}}}}}}}}}}}}

As one can see, the location field (which is mandatory according to http://wiki.xmms2.xmms.se/wiki/MPRIS ) is absent:

{{{{{{
shlomi:~/Docs/Notes/To_Do$ dbus-send --type=method_call --dest=org.kde.amarok /TrackList --print-reply=literal org.freedesktop.MediaPlayer.GetMetadata int32:0 | grep -i location | wc -l
0
shlomi:~/Docs/Notes/To_Do$
}}}}}}
Comment 1 Seb Ruiz 2008-10-23 10:27:58 UTC
SVN commit 875071 by seb:

Add the location attribute to the GetMetadata dbus MPRIS specification.
BUG: 173324


 M  +1 -0      ChangeLog  
 M  +1 -0      src/dbus/PlayerDBusHandler.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=875071