Bug 173007 - JJ: MPRIS Pause should toggle play/pause
Summary: JJ: MPRIS Pause should toggle play/pause
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 2.0-beta
Platform: Gentoo Packages Linux
: HI normal (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-17 06:41 UTC by Jeff
Modified: 2009-12-09 11:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff 2008-10-17 06:41:48 UTC
Version:           1.90 (using KDE 4.1.2)
Compiler:          gcc version 4.1.2 (Gentoo 4.1.2 p1.1)  
OS:                Linux
Installed from:    Gentoo Packages

Amarok for KDE 3.x had a dcop method called PlayPause which was very useful for example to bind a hotkey to.  It allowed Play-Pause-Resume functionality all in one button (Play if not playing or paused, Pause if playing), which is usually the desired behavior for a typical Play/Pause button.

However, Amarok 2 has dbus methods Play and Pause, but no PlayPause.  It's especially problematic with most multimedia keyboard which have a Play/Pause button.  Someone would have to write a script to track the playback status of amarok and decide which method to call.  It would be very nice to have the old PlayPause method. Thanks.
Comment 1 Seb Ruiz 2008-10-17 06:45:50 UTC
MPRIS docs specify that Pause should toggle play/pause. Should be an easy fix.
Comment 2 Seb Ruiz 2008-10-17 09:33:03 UTC
SVN commit 872418 by seb:

The MPRIS spec states that Pause should actually be a play-pause action.
BUG: 173007


 M  +1 -1      PlayerDBusHandler.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=872418